[Committed] [PATCH, ifcvt] Fix PR63917

2014-12-11 Thread Zhenqiang Chen
> -Original Message- > From: Richard Henderson [mailto:r...@redhat.com] > Sent: Wednesday, December 10, 2014 8:55 AM > To: Zhenqiang Chen > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [Ping] [PATCH, ifcvt] Fix PR63917 > > On 12/04/2014 05:16 PM, Zhenqiang Che

Re: [Ping] [PATCH, ifcvt] Fix PR63917

2014-12-09 Thread Richard Henderson
On 12/04/2014 05:16 PM, Zhenqiang Chen wrote: > +static rtx > +cc_in_cond (rtx cond) > +{ > + if ((HAVE_cbranchcc4) && cond Silly parens around the HAVE_cbranchcc4. > + && (GET_MODE_CLASS (GET_MODE (XEXP (cond, 0))) == MODE_CC)) More silly parens around the ==. > + /* Skip it if the inst

[Ping] [PATCH, ifcvt] Fix PR63917

2014-12-04 Thread Zhenqiang Chen
Ping? Thanks! -Zhenqiang -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen Sent: Monday, December 01, 2014 3:14 PM To: 'H.J. Lu' Cc: Richard Henderson; GCC Patches Subject: RE: [PATCH, ifcvt] F

RE: [PATCH, ifcvt] Fix PR63917

2014-11-30 Thread Zhenqiang Chen
> -Original Message- > From: H.J. Lu [mailto:hjl.to...@gmail.com] > Sent: Friday, November 28, 2014 10:45 PM > To: Zhenqiang Chen > Cc: Richard Henderson; GCC Patches > Subject: Re: [PATCH, ifcvt] Fix PR63917 > > On Sun, Nov 23, 2014 at 7:47 PM,

Re: [PATCH, ifcvt] Fix PR63917

2014-11-28 Thread H.J. Lu
On Sun, Nov 23, 2014 at 7:47 PM, Zhenqiang Chen wrote: > >> -Original Message- >> From: Richard Henderson [mailto:r...@redhat.com] >> Sent: Friday, November 21, 2014 2:27 AM >> To: Zhenqiang Chen; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH, ifcvt] Fix

RE: [PATCH, ifcvt] Fix PR63917

2014-11-23 Thread Zhenqiang Chen
> -Original Message- > From: Richard Henderson [mailto:r...@redhat.com] > Sent: Friday, November 21, 2014 2:27 AM > To: Zhenqiang Chen; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, ifcvt] Fix PR63917 > > On 11/20/2014 10:48 AM, Zhenqiang Chen wrote: > > +/

Re: [PATCH, ifcvt] Fix PR63917

2014-11-20 Thread Richard Henderson
On 11/20/2014 10:48 AM, Zhenqiang Chen wrote: > +/* Check X clobber CC reg or not. */ > + > +static bool > +clobber_cc_p (rtx x) > +{ > + RTX_CODE code = GET_CODE (x); > + int i; > + > + if (code == CLOBBER > + && REG_P (XEXP (x, 0)) > + && (GET_MODE_CLASS (GET_MODE (XEXP (x, 0))) ==

Re: [PATCH, ifcvt] Fix PR63917

2014-11-20 Thread H.J. Lu
On Thu, Nov 20, 2014 at 1:48 AM, Zhenqiang Chen wrote: > Hi, > > r217646 enhances ifcvt to handle cbranchcc4 instruction. But ifcvt does not > strictly check the dependence before moving instructions before IF. Then > some instructions, which clobber CC, are inserted before the cbranchcc4 > instru

[PATCH, ifcvt] Fix PR63917

2014-11-20 Thread Zhenqiang Chen
Hi, r217646 enhances ifcvt to handle cbranchcc4 instruction. But ifcvt does not strictly check the dependence before moving instructions before IF. Then some instructions, which clobber CC, are inserted before the cbranchcc4 instruction. For the case in the patch, ifcvt transfers code from 5: