Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-30 Thread H.J. Lu
On Tue, Aug 30, 2011 at 6:55 AM, Ilya Tocar wrote: > Little fix. > > 2011/8/30 Ilya Tocar : >> Sorry. Regenerated. >> >> 2011/8/30 H.J. Lu : >>> On Tue, Aug 30, 2011 at 2:42 AM, Ilya Tocar wrote: Fixed. 2011/8/26 H.J. Lu : > On Fri, Aug 26, 2011 at 8:47 AM, H.J. Lu wrote:

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-30 Thread H.J. Lu
On Tue, Aug 30, 2011 at 2:42 AM, Ilya Tocar wrote: > Fixed. > > 2011/8/26 H.J. Lu : >> On Fri, Aug 26, 2011 at 8:47 AM, H.J. Lu wrote: >>> On Fri, Aug 26, 2011 at 8:06 AM, Ilya Tocar wrote: Done. Also fixed  changelog:  2011-08-26  Ilya Tocar        

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-26 Thread H.J. Lu
On Fri, Aug 26, 2011 at 8:47 AM, H.J. Lu wrote: > On Fri, Aug 26, 2011 at 8:06 AM, Ilya Tocar wrote: >> Done. >> >> >> >> Also fixed  changelog: >> >>  2011-08-26  Ilya Tocar   >> >>             * config/i386/fmaintrin.h: New. >>             * config.gcc: Add fmaintrin.h. >>             * config/

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-26 Thread H.J. Lu
On Fri, Aug 26, 2011 at 8:06 AM, Ilya Tocar wrote: > Done. > > > > Also fixed  changelog: > >  2011-08-26  Ilya Tocar   > >             * config/i386/fmaintrin.h: New. >             * config.gcc: Add fmaintrin.h. >             * config/i386/i386.c >            (enum ix86_builtins) : New. >        

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-26 Thread H.J. Lu
On Fri, Aug 26, 2011 at 1:41 AM, Ilya Tocar wrote: > So if this is ok can someone please commit it? > > 2011/8/25 Ilya Tocar : >> Fixed. >> >> Changelog: >> >> 2011-08-25  Ilya Tocar   >> >>             * config/i386/fmaintrin.h: New. >>             * config.gcc: Add fmaintrin.h. >>             *

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-25 Thread Ilya Tocar
Fixed. Changelog: 2011-08-25 Ilya Tocar * config/i386/fmaintrin.h: New. * config.gcc: Add fmaintrin.h. * config/i386/i386.c (enum ix86_builtins) : New. : Likewise. * config/i386/sse.md (fmai_vmfmadd_): New.

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-25 Thread Jakub Jelinek
On Thu, Aug 25, 2011 at 02:47:51PM +0400, Ilya Tocar wrote: > Sorry. Like this? No. >              * gcc.target/i386/sse-12.c: Add -mfma. >              * gcc.target/i386/sse-13.c: Likewise. >              * gcc.target/i386/sse-14.c: Likewise. >              * gcc.target/i386/sse-22.c: Likewise. >

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-25 Thread Ilya Tocar
Sorry. Like this? Changelog: 2011-08-25  Ilya Tocar                * config/i386/fmaintrin.h: New.              * config.gcc: Add fmaintrin.h.              * config/i386/i386.c (enum ix86_builtins) : New.              : Likewise.              * config/i386/sse.md (fmai_vmfmadd_): Ne

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-25 Thread Uros Bizjak
On Thu, Aug 25, 2011 at 10:18 AM, Ilya Tocar wrote: > Changelog: > > 2011-08-25  Ilya Tocar   > >               * config/i386/fmaintrin.h: New. >               * config.gcc: Add fmaintrin.h. >               * config/i386/i386.c >               * (IX86_BUILTIN_VFMADDSS3): New. >               (IX8

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-24 Thread Uros Bizjak
On Wed, Aug 24, 2011 at 2:39 PM, Ilya Tocar wrote: Also, why is fmaintrin.h including immintrin.h?  You can't include fmaintrin.h directly and x86intrin.h has already included it before including fmaintrin.h. >>> Makes sense. Removed it. >> >> Do we need to add -mfma to gcc.

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-24 Thread Uros Bizjak
On Wed, Aug 24, 2011 at 11:31 AM, Ilya Tocar wrote: > 2011/8/24 Jakub Jelinek : >> On Wed, Aug 24, 2011 at 12:48:06PM +0400, Ilya Tocar wrote: >>> Removed extra blank lines and pass tests through "indent". >> >> You haven't: > Ah sorry only noticed one in sse.md. >> >> @@ -25113,6 +25125,9 @@ stat

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-24 Thread Ilya Tocar
2011/8/24 Jakub Jelinek : > On Wed, Aug 24, 2011 at 12:48:06PM +0400, Ilya Tocar wrote: >> Removed extra blank lines and pass tests through "indent". > > You haven't: Ah sorry only noticed one in sse.md. > > @@ -25113,6 +25125,9 @@ static const struct builtin_description > bdesc_multi_arg[] = >  

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-24 Thread Jakub Jelinek
On Wed, Aug 24, 2011 at 12:48:06PM +0400, Ilya Tocar wrote: > Removed extra blank lines and pass tests through "indent". You haven't: @@ -25113,6 +25125,9 @@ static const struct builtin_description bdesc_multi_arg[] = "__built

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-24 Thread Ilya Tocar
Removed extra blank lines and pass tests through "indent". 2011/8/23 Uros Bizjak : > On Tue, Aug 23, 2011 at 4:19 PM, Ilya Tocar wrote: >> I removed unnecessary expands/builtins and tests are now compiled with -O2. >> Is this version ok? > > OK with minor comments: > > - Please remove extra blank

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-23 Thread Uros Bizjak
On Tue, Aug 23, 2011 at 4:19 PM, Ilya Tocar wrote: > I removed unnecessary expands/builtins and tests are now compiled with -O2. > Is this version ok? OK with minor comments: - Please remove extra blank lines you introduced in sse.md - Also, I'd recomend you to pass new testcases through "indent

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-22 Thread Uros Bizjak
On Mon, Aug 22, 2011 at 6:25 PM, Ilya Tocar wrote: >> You don't need to add "negated" versions, one FMA builtin per mode is >> enough, please see existing FMA4 descriptions. Just put unary minus >> sign in the intrinsics header for "negated" operand and let GCC do its >> job. Please see existing

Re: [PATCH, i386, testsuite] FMA intrinsics

2011-08-20 Thread Uros Bizjak
Hello! > This patch adds intrinsics for FMA instruction set along with tests for them. > Bootstraps and passes make check (including make check on simulator > for new runtime tests). ? ? ? ? ? ? ? * config/i386/fmaintrin.h: New. It is not included in the patch. ? ? ? ? ? ? ? * config.gcc: Add f