Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-19 Thread Richard Sandiford
Christian Bruel writes: > Index: gcc/config/sh/sh.md > === > --- gcc/config/sh/sh.md (revision 202699) > +++ gcc/config/sh/sh.md (working copy) > @@ -6894,9 +6894,11 @@ label: > ;; reloading MAC subregs otherwise. For th

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-19 Thread Oleg Endo
Hi, On Thu, 2013-09-19 at 10:44 +0200, Christian Bruel wrote: > Hi Kaz, Oleg, > > On 09/19/2013 01:15 AM, Kaz Kojima wrote: > > Christian Bruel wrote: > >> && (!can_create_pseudo_p () && REG_P (operands[0]) && REG_P (operands[1]))" > >> > >> is necessary ? > > It looks an another hack to allow t

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-19 Thread Christian Bruel
Hi Kaz, Oleg, On 09/19/2013 01:15 AM, Kaz Kojima wrote: > Christian Bruel wrote: >> && (!can_create_pseudo_p () && REG_P (operands[0]) && REG_P (operands[1]))" >> >> is necessary ? > It looks an another hack to allow the 2nd and 3rd alternatives only > when reloading. If so, it might be a bit cl

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Oleg Endo
On Thu, 2013-09-19 at 08:15 +0900, Kaz Kojima wrote: > Christian Bruel wrote: > > && (!can_create_pseudo_p () && REG_P (operands[0]) && REG_P (operands[1]))" > > > > is necessary ? > > It looks an another hack to allow the 2nd and 3rd alternatives only > when reloading. If so, it might be a bit

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Kaz Kojima
Christian Bruel wrote: > && (!can_create_pseudo_p () && REG_P (operands[0]) && REG_P (operands[1]))" > > is necessary ? It looks an another hack to allow the 2nd and 3rd alternatives only when reloading. If so, it might be a bit cleaner to use a special predicate like ;; Returns 1 if OP can be

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Christian Bruel
Hi Oleg, On 09/18/2013 02:59 PM, Oleg Endo wrote: > On Wed, 2013-09-18 at 09:55 +0200, Christian Bruel wrote: >> Hi Richard, >> >> On 09/16/2013 07:10 PM, Richard Sandiford wrote: >>> Hi Christian, >>> >>> Christian Bruel writes: @@ -6893,11 +6894,14 @@ label: ;; reloading MAC subregs

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Oleg Endo
On Wed, 2013-09-18 at 09:55 +0200, Christian Bruel wrote: > Hi Richard, > > On 09/16/2013 07:10 PM, Richard Sandiford wrote: > > Hi Christian, > > > > Christian Bruel writes: > >> @@ -6893,11 +6894,14 @@ label: > >> ;; reloading MAC subregs otherwise. For that probably special patterns > >> ;;

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-18 Thread Christian Bruel
Hi Richard, On 09/16/2013 07:10 PM, Richard Sandiford wrote: > Hi Christian, > > Christian Bruel writes: >> @@ -6893,11 +6894,14 @@ label: >> ;; reloading MAC subregs otherwise. For that probably special patterns >> ;; would be required. >> (define_insn "*mov_reg_reg" >> - [(set (match_opera

Re: [PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-16 Thread Richard Sandiford
Hi Christian, Christian Bruel writes: > @@ -6893,11 +6894,14 @@ label: > ;; reloading MAC subregs otherwise. For that probably special patterns > ;; would be required. > (define_insn "*mov_reg_reg" > - [(set (match_operand:QIHI 0 "arith_reg_dest" "=r") > - (match_operand:QIHI 1 "register

[PATCH, committed] SH: Fix PR58314 (unsatisfied constraints)

2013-09-13 Thread Christian Bruel
For 4.8 and 4.9 2013-09-13 Christian Bruel PR target/58314 * config/sh/sh.md (mov_reg_reg): Allow memory reloads. 2013-09-13 Christian Bruel PR target/58314 * gcc.target/sh/torture/pr58314.c: New test. Index: gcc/config/sh/sh.md ===