Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-07-17 Thread Tom de Vries
On 06/25/2018 03:02 PM, Tom de Vries wrote: > On 06/25/2018 02:45 PM, Nathan Sidwell wrote: >> On 06/25/2018 08:25 AM, Tom de Vries wrote: >> >>> If we'd implemented something like this in gas: >>> ... >>> .insn >>> .byte 0x66 >>> .endinsn >>> ... >>> we could fix this more generically. >> >> Doesn

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-26 Thread Jakub Jelinek
On Tue, Jun 26, 2018 at 11:20:32AM +0200, Rainer Orth wrote: > > Committed (after moving the testcase to gcc.target/i386). > > the new testcase FAILs on 32-bit Solaris/x86 > > FAIL: gcc.target/i386/pr86257.c scan-assembler data16[ \\t]*leaq > > and, according to gcc-testresults, also on i586-unk

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-26 Thread Rainer Orth
Hi Tom, > On 06/24/2018 11:56 PM, Jan Hubicka wrote: >>> Hi, >>> >>> [ The analysis of this PR was done at https://stackoverflow.com/a/33557963 , >>> November 2015. ] >>> >>> This tls sequence: >>> ... >>> 0x00 .byte 0x66 >>> 0x01 leaq x@tlsgd(%rip),%rdi >>> 0x08 .word 0x >>> 0x0a rex64 >>> 0

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/25/2018 02:45 PM, Nathan Sidwell wrote: > On 06/25/2018 08:25 AM, Tom de Vries wrote: > >> If we'd implemented something like this in gas: >> ... >> .insn >> .byte 0x66 >> .endinsn >> ... >> we could fix this more generically. > > Doesn't arm gas provide this functionality with some target-

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Nathan Sidwell
On 06/25/2018 08:25 AM, Tom de Vries wrote: If we'd implemented something like this in gas: ... .insn .byte 0x66 .endinsn ... we could fix this more generically. Doesn't arm gas provide this functionality with some target-specific pseudo? It'd be good to copy that. ah, inst: @cindex @code

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/24/2018 11:59 PM, Jan Hubicka wrote: > Hi, > searching for other occurences I see: > jan@skylake:~/trunk/gcc/config/i386> grep ASM_BYTE *md *.c > i386.md:return ASM_BYTE "0x9e"; > i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); > i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); >

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/24/2018 11:56 PM, Jan Hubicka wrote: >> Hi, >> >> [ The analysis of this PR was done at https://stackoverflow.com/a/33557963 , >> November 2015. ] >> >> This tls sequence: >> ... >> 0x00 .byte 0x66 >> 0x01 leaq x@tlsgd(%rip),%rdi >> 0x08 .word 0x >> 0x0a rex64 >> 0x0b call __tls_get_addr

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-24 Thread Jan Hubicka
Hi, searching for other occurences I see: jan@skylake:~/trunk/gcc/config/i386> grep ASM_BYTE *md *.c i386.md:return ASM_BYTE "0x9e"; i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); i386.c: fputs (ASM_BYTE "0x48, 0x8d, 0xa4, 0x24, 0x00,

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-24 Thread Jan Hubicka
> Hi, > > [ The analysis of this PR was done at https://stackoverflow.com/a/33557963 , > November 2015. ] > > This tls sequence: > ... > 0x00 .byte 0x66 > 0x01 leaq x@tlsgd(%rip),%rdi > 0x08 .word 0x > 0x0a rex64 > 0x0b call __tls_get_addr@plt > ... > starts with an insn prefix, produced usi

[PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-24 Thread Tom de Vries
Hi, [ The analysis of this PR was done at https://stackoverflow.com/a/33557963 , November 2015. ] This tls sequence: ... 0x00 .byte 0x66 0x01 leaq x@tlsgd(%rip),%rdi 0x08 .word 0x 0x0a rex64 0x0b call __tls_get_addr@plt ... starts with an insn prefix, produced using a .byte. When using a .l