Re: [PATCH, PR43920, 3/9] Cleanup.

2011-04-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/01/11 09:15, Tom de Vries wrote: > On 04/01/2011 05:01 PM, Jakub Jelinek wrote: >> On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote: >>> Reposting, with ChangeLog. >> >> Similarly one of your patches had >> * gcc/cfgcleanup.c (wh

Re: [PATCH, PR43920, 3/9] Cleanup.

2011-04-01 Thread Tom de Vries
On 04/01/2011 05:01 PM, Jakub Jelinek wrote: > On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote: >> Reposting, with ChangeLog. > > Similarly one of your patches had > * gcc/cfgcleanup.c (whatever): Whatever. > in the ChangeLog, should be just > * cfgcleanup.c (whatever): Wha

Re: [PATCH, PR43920, 3/9] Cleanup.

2011-04-01 Thread Tom de Vries
Reposting, with ChangeLog. 2011-04-01 Tom de Vries PR target/43920 * gcc/cfgcleanup.c (try_crossjump_bb): Remove 2 superfluous variables. diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c --- gcc/cfgcleanup.c (working copy) +++ gcc/cfgcleanup.c (working copy) @@ -1961,7 +1961,6 @@ edge e, e2, fal

Re: [PATCH, PR43920, 3/9] Cleanup.

2011-03-31 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/31/11 12:29, Tom de Vries wrote: > Cleans up some code. OK. Note that it would have helped if you mentioned that "bb" was a loop invariant and thus "ev" and "ev2" were loop invariants that could be replaced by "bb". Please install.. Thanks, j

[PATCH, PR43920, 3/9] Cleanup.

2011-03-31 Thread Tom de Vries
Cleans up some code. Thanks, - Tom diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c --- gcc/cfgcleanup.c (working copy) +++ gcc/cfgcleanup.c (working copy) @@ -1961,7 +1961,6 @@ edge e, e2, fallthru; bool changed; unsigned max, ix, ix2; - basic_block ev, ev2; /* Nothing to do if there is n