Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-05 Thread Dominique Dhumieres
> this patch is ready for commit now. Please apply. There have been no > objections > against doing dg-do compile only, since my last post in August. Since I am stubborn, I have made the test 'dg-do run' and committed the patch as revision r218422. Thanks for the patch, Dominique

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-03 Thread FX
> this patch is ready for commit now. Please apply. There have been no > objections > against doing dg-do compile only, since my last post in August. I wasn’t back on active duty in August, so I didn’t follow that. But if the only argument for compile-test over run-test is the runtime, then I do

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-03 Thread Dominique d'Humières
> Le 3 déc. 2014 à 18:08, Andre Vehreschild a écrit : > > Hi, > > this patch is ready for commit now. Please apply. There have been no > objections > against doing dg-do compile only, since my last post in August. Not really true, I do have objections, but I won’t fight for them. I still th

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-12-03 Thread Andre Vehreschild
Hi, this patch is ready for commit now. Please apply. There have been no objections against doing dg-do compile only, since my last post in August. - Andre On Tue, 26 Aug 2014 11:30:12 +0200 Andre Vehreschild wrote: > Hi, > > On Sun, 17 Aug 2014 15:06:02 +0200 > Mikael Morin wrote: > > > L

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-26 Thread Andre Vehreschild
Hi, On Sun, 17 Aug 2014 15:06:02 +0200 Mikael Morin wrote: > Le 17/08/2014 14:26, Dominique Dhumieres a écrit : > > As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html > > > >> the testcase should check that the code generated is actually working, > >> not just that the ICE d

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-17 Thread Mikael Morin
Le 17/08/2014 14:26, Dominique Dhumieres a écrit : > As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html > >> the testcase should check that the code generated is actually working, >> not just that the ICE disappeared. ... > Well, this is for another patch where deferred charac

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-17 Thread Dominique Dhumieres
As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html > the testcase should check that the code generated is actually working, > not just that the ICE disappeared. ... thus I think the test should be run, i.e., '! { dg-do compile }' should be replaced with '! { dg-do run }' (I ha

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-17 Thread Mikael Morin
Hello, Le 06/08/2014 21:23, Andre Vehreschild a écrit : > Hi, > [...] > > *** gcc/fortran/Changelog *** > 2014-08-06 Andre Vehreschild > > PR fortran/60414 > * interface.c (compare_parameter): Fixing ICE when argument > of a generic is a reference into an array. > ***

[PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

2014-08-06 Thread Andre Vehreschild
Hi, thanks for all the input. The issue to patch is an ICE while compiling a call of a generic method using an array reference, e.g., this.Check(vec(1)) where Check aggregates an implementation for an array parameter and one with a scalar parameter. Based on Mikael's input, I analyzed the code