Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-07 Thread Ilya Enkovich
On 06 Apr 20:41, Jan Hubicka wrote: > > 2015-04-03 20:12 GMT+03:00 Jan Hubicka : > > >> > > >> Currently ipa_comdats doesn't set comdat groups for thunks. At the > > > > > > I see, that is a bug. It is supposed to keep thunks in the same section > > > as their target (thunks doesn't really work ac

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-06 Thread Jan Hubicka
> 2015-04-03 20:12 GMT+03:00 Jan Hubicka : > >> > >> Currently ipa_comdats doesn't set comdat groups for thunks. At the > > > > I see, that is a bug. It is supposed to keep thunks in the same section > > as their target (thunks doesn't really work across sections on some target, > > like PPC, beca

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-06 Thread Ilya Enkovich
2015-04-03 20:12 GMT+03:00 Jan Hubicka : >> >> Currently ipa_comdats doesn't set comdat groups for thunks. At the > > I see, that is a bug. It is supposed to keep thunks in the same section > as their target (thunks doesn't really work across sections on some target, > like PPC, because there is n

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-03 Thread Jan Hubicka
> 2015-04-02 20:04 GMT+03:00 Jan Hubicka : > >> Hi, > >> > >> With r221574 (https://gcc.gnu.org/ml/gcc-cvs/2015-03/msg00495.html) thunks > >> don't get comdat groups assigned and this causes a failure in cgraph > >> checker for instrumentation thunks. It happens because instrumentation > >> thu

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-03 Thread Ilya Enkovich
2015-04-02 20:04 GMT+03:00 Jan Hubicka : >> Hi, >> >> With r221574 (https://gcc.gnu.org/ml/gcc-cvs/2015-03/msg00495.html) thunks >> don't get comdat groups assigned and this causes a failure in cgraph checker >> for instrumentation thunks. It happens because instrumentation thunk may >> referen

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-02 Thread Jan Hubicka
> Hi, > > With r221574 (https://gcc.gnu.org/ml/gcc-cvs/2015-03/msg00495.html) thunks > don't get comdat groups assigned and this causes a failure in cgraph checker > for instrumentation thunks. It happens because instrumentation thunk may > reference local symbol in comdat not being in comdat

[PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-02 Thread Ilya Enkovich
Hi, With r221574 (https://gcc.gnu.org/ml/gcc-cvs/2015-03/msg00495.html) thunks don't get comdat groups assigned and this causes a failure in cgraph checker for instrumentation thunks. It happens because instrumentation thunk may reference local symbol in comdat not being in comdat by itself.