Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-05 Thread Richard Earnshaw
On Thu, 2011-05-05 at 13:08 +0100, Julian Brown wrote: > On Tue, 03 May 2011 15:49:38 +0100 > Richard Earnshaw wrote: > > > > > On Tue, 2011-05-03 at 13:49 +0100, Julian Brown wrote: > > > Hi, > > > > > > This patch fixes vset_lane intrinsic variants for D-register sized > > > variables. A typ

Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-05 Thread Julian Brown
On Tue, 03 May 2011 15:49:38 +0100 Richard Earnshaw wrote: > > On Tue, 2011-05-03 at 13:49 +0100, Julian Brown wrote: > > Hi, > > > > This patch fixes vset_lane intrinsic variants for D-register sized > > variables. A typo meant that the wrong lane would be set in many > > circumstances. > > >

Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-03 Thread Joseph S. Myers
On Tue, 3 May 2011, Richard Earnshaw wrote: > > gcc/ > > * config/arm/neon.md (vec_set_internal): Fix misplaced > > parenthesis in D-register case. > > Presumably this is a silent 'wrong-code' bug. If so, what about > released compilers? And what about an execution testcase that fai

Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-03 Thread Richard Earnshaw
On Tue, 2011-05-03 at 13:49 +0100, Julian Brown wrote: > Hi, > > This patch fixes vset_lane intrinsic variants for D-register sized > variables. A typo meant that the wrong lane would be set in many > circumstances. > > Tested manually only. OK to apply? > > Thanks, > > Julian > > ChangeLog >

Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-03 Thread Ramana Radhakrishnan
On 03/05/11 13:49, Julian Brown wrote: Hi, This patch fixes vset_lane intrinsic variants for D-register sized variables. A typo meant that the wrong lane would be set in many circumstances. Tested manually only. OK to apply? Ok - yes this looks almost obvious but please do a sanity regression

[PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-03 Thread Julian Brown
Hi, This patch fixes vset_lane intrinsic variants for D-register sized variables. A typo meant that the wrong lane would be set in many circumstances. Tested manually only. OK to apply? Thanks, Julian ChangeLog gcc/ * config/arm/neon.md (vec_set_internal): Fix misplaced parenthesi