'gomp_map_vars' locking protocol (was: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime)

2020-05-19 Thread Thomas Schwinge
Hi Jakub, Julian! Can you please help me understand the following: On 2018-06-19T10:01:20-0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in libgomp. (This got committed as r261813, 2018-06-20. The code has seen some changes in the mean time, but th

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2019-12-11 Thread Thomas Schwinge
Hi! On 2018-06-19T10:01:20-0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in libgomp. > --- a/libgomp/libgomp.h > +++ b/libgomp/libgomp.h > @@ -853,6 +853,8 @@ struct splay_tree_key_s { >uintptr_t tgt_offset; >/* Reference count. */ >uin

In 'libgomp/target.c:gomp_exit_data', remove open-coded 'gomp_remove_var' (was: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime)

2019-12-09 Thread Thomas Schwinge
Hi! On 2018-06-19T10:01:20-0700, Cesar Philippidis wrote: > --- a/libgomp/target.c > +++ b/libgomp/target.c > +attribute_hidden bool > +gomp_remove_var (struct gomp_device_descr *devicep, splay_tree_key k) > +{ > + bool is_tgt_unmapped = false; > + splay_tree_remove (&devicep->mem_map, k); > +

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2019-05-29 Thread Thomas Schwinge
Hi Jakub! Any comments on my questions, please? On Thu, 02 May 2019 16:03:09 +0200, I wrote: > I'm currently working on other pending OpenACC 'deviceptr' clause patches > from our backlog, and I noticed the following, which I don't understand. > You reviewed and approved this patch, could you ple

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2019-05-02 Thread Thomas Schwinge
Hi Jakub! I'm currently working on other pending OpenACC 'deviceptr' clause patches from our backlog, and I noticed the following, which I don't understand. You reviewed and approved this patch, could you please help? On Tue, 19 Jun 2018 10:01:20 -0700, Cesar Philippidis wrote: > --- a/libgomp/

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2018-06-20 Thread Cesar Philippidis
On 06/20/2018 10:03 AM, Jakub Jelinek wrote: > On Wed, Jun 20, 2018 at 09:59:29AM -0700, Cesar Philippidis wrote: >> If it means anything, we have a significant async change that removes >> the async_refcount field in that struct. > > Wasn't async_refcount removed 2 years ago? You're right. I wa

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2018-06-20 Thread Jakub Jelinek
On Wed, Jun 20, 2018 at 09:59:29AM -0700, Cesar Philippidis wrote: > > I'm not entirely happy about this, it grows the structure for not just > > OpenACC, but also OpenMP which will never use it. Are there any fields > > not used by OpenACC? E.g. is link_key used? > > Or could the dynamic refcoun

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2018-06-20 Thread Cesar Philippidis
On 06/20/2018 09:45 AM, Jakub Jelinek wrote: > On Tue, Jun 19, 2018 at 10:01:20AM -0700, Cesar Philippidis wrote: >> >From 53ee03231c5e6e4747b4ef01335079a2d4a98480 Mon Sep 17 00:00:00 2001 >> From: Cesar Philippidis >> Date: Tue, 19 Jun 2018 09:33:04 -0700 >> Subject: [PATCH 7/7] runtime changes

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2018-06-20 Thread Jakub Jelinek
On Tue, Jun 19, 2018 at 10:01:20AM -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 data clause semantics in libgomp. > > Is it OK for trunk? > 2018-06-19 Chung-Lin Tang > Thomas Schwinge > Cesar Philippidis > > libgomp/ > * libgomp.h (

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime tests

2018-06-19 Thread Cesar Philippidis
This patch updates the existing OpenACC libgomp runtime tests with the new OpenACC 2.5 data clause semantics. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis libgomp/ * testsuite/libgomp.oacc-c-c++-common/data-already-1.c: Update test case

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime

2018-06-19 Thread Cesar Philippidis
This patch implements the OpenACC 2.5 data clause semantics in libgomp. Is it OK for trunk? Cesar 2018-06-19 Chung-Lin Tang Thomas Schwinge Cesar Philippidis libgomp/ * libgomp.h (struct splay_tree_key_s): Add dynamic_refcount member. (gomp_acc_remove_pointer): Update declarati