On Mon, Feb 4, 2013 at 1:45 PM, Cary Coutant wrote:
>> Ahh, good catch. Fixed as attached.
>
> Looks good, thanks. OK for the google/gcc-4_7 branch.
>
> (And, yes, please do port this to trunk when Stage 1 reopens.)
Thanks. Committed.
> Ahh, good catch. Fixed as attached.
Looks good, thanks. OK for the google/gcc-4_7 branch.
(And, yes, please do port this to trunk when Stage 1 reopens.)
-cary
On Mon, Feb 4, 2013 at 11:56 AM, Cary Coutant wrote:
>> @@ -22385,21 +22448,21 @@
>> static void
>> output_indirect_strings (void)
>> {
>> + switch_to_section (debug_str_section);
>>if (!dwarf_split_debug_info)
>> -{
>> - switch_to_section (debug_str_section);
>> - htab_trave
> @@ -22385,21 +22448,21 @@
> static void
> output_indirect_strings (void)
> {
> + switch_to_section (debug_str_section);
>if (!dwarf_split_debug_info)
> -{
> - switch_to_section (debug_str_section);
> - htab_traverse (debug_str_hash, output_indirect_string, NULL);
> -}
>
The enclosed patch for Google 4.7 is an optimization for debug strings
under -gsplit-dwarf. Currently under -gsplit-dwarf, all strings with
DW_FORM_strp end up in the .debug_str.dwo section, which requires any
string not destined for the .dwo to use DW_FORM_string, disallowing any
duplication remo
