Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-13 Thread Xinliang David Li
Ok. David On Fri, Sep 13, 2013 at 7:21 AM, Teresa Johnson wrote: > Testing passes, is the below patch ok for google/4_8? > Thanks, Teresa > > On Thu, Sep 12, 2013 at 10:18 PM, Teresa Johnson wrote: >> On Thu, Sep 12, 2013 at 2:32 PM, Xinliang David Li >> wrote: >>> When absolute path is speci

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-13 Thread Teresa Johnson
Testing passes, is the below patch ok for google/4_8? Thanks, Teresa On Thu, Sep 12, 2013 at 10:18 PM, Teresa Johnson wrote: > On Thu, Sep 12, 2013 at 2:32 PM, Xinliang David Li wrote: >> When absolute path is specified for the object file, no prefix will be >> prepended to the gcda path. If you

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Teresa Johnson
On Thu, Sep 12, 2013 at 2:32 PM, Xinliang David Li wrote: > When absolute path is specified for the object file, no prefix will be > prepended to the gcda path. If you record the cwd as in the > _gcov_profile_prefix variable, at profile dump time, the prefix will > be wrong -- as it is never used.

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Teresa Johnson
On Thu, Sep 12, 2013 at 1:20 PM, Xinliang David Li wrote: > On Thu, Sep 12, 2013 at 1:06 PM, Teresa Johnson wrote: >> After porting r198033 from google/4_7 to google/4_8 a test case failed >> with an assert when trying to take the strlen of profile_data_prefix. >> >> In most cases this is either

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Xinliang David Li
When absolute path is specified for the object file, no prefix will be prepended to the gcda path. If you record the cwd as in the _gcov_profile_prefix variable, at profile dump time, the prefix will be wrong -- as it is never used. David On Thu, Sep 12, 2013 at 2:07 PM, Teresa Johnson wrote: >

[Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Teresa Johnson
After porting r198033 from google/4_7 to google/4_8 a test case failed with an assert when trying to take the strlen of profile_data_prefix. In most cases this is either set from the directory specified to -fprofile-generate=, or to getpwd when a directory is not specified. However, the exception

Re: [Google] Fix test failure after porting __gcov_get_profile_prefix from google/4_7

2013-09-12 Thread Xinliang David Li
On Thu, Sep 12, 2013 at 1:06 PM, Teresa Johnson wrote: > After porting r198033 from google/4_7 to google/4_8 a test case failed > with an assert when trying to take the strlen of profile_data_prefix. > > In most cases this is either set from the directory specified to > -fprofile-generate=, or to