The patch is ok.
David
On Thu, Oct 10, 2013 at 8:09 AM, Dehao Chen wrote:
> Patch updated.
>
> Thanks,
> Dehao
>
> On Wed, Oct 9, 2013 at 10:45 PM, Xinliang David Li wrote:
>> > /* Program behavior changed, original promoted (and inlined) target is not
>> > hot any more. Will avoid promote th
Patch updated.
Thanks,
Dehao
On Wed, Oct 9, 2013 at 10:45 PM, Xinliang David Li wrote:
> > /* Program behavior changed, original promoted (and inlined) target is not
> > hot any more. Will avoid promote the original target. */
> > if (total >= info->first * 0.5)
> > return false;
>
> This
> /* Program behavior changed, original promoted (and inlined) target is not
> hot any more. Will avoid promote the original target. */
> if (total >= info->first * 0.5)
> return false;
This part is still not clear: Difference between OLD_INFO and INFO,
factor 0.5 comes from where etc.
> g
Hi, David,
Thanks for the review. Patch updated.
Dehao
On Sun, Oct 6, 2013 at 11:54 AM, Xinliang David Li wrote:
> Adding additional early inline + value transform (calling them as
> utility functions) is 'unconventional' way of invoking passes. It
> would be helpful to do more heavy documentat
Adding additional early inline + value transform (calling them as
utility functions) is 'unconventional' way of invoking passes. It
would be helpful to do more heavy documentation by providing more
examples and explaining why simply augmenting the indirect target info
for promoted icall site with i
This patch fixes the issue of indirect call promotion while using
AutoFDO optimized binary to collect profile, and use the new profile
to re-optimize the binary. Before the patch, the indirect call is
promoted (and likely inlined) in the profiled binary, and will not be
promoted in the new iteratio
