Re: [GOOGLE] Fix incorrect detection of recursive calls during LIPO IPA inlining

2014-04-10 Thread Xinliang David Li
Looks good to me. David On Thu, Apr 10, 2014 at 2:04 PM, Teresa Johnson wrote: > This patch fixes an issue where self-recursive calls were missed > during ipa inlining in LIPO compiles, since the resolved nodes were > not checked. When a self-recursive call was inlined incorrectly, > ipa_inline

[GOOGLE] Fix incorrect detection of recursive calls during LIPO IPA inlining

2014-04-10 Thread Teresa Johnson
This patch fixes an issue where self-recursive calls were missed during ipa inlining in LIPO compiles, since the resolved nodes were not checked. When a self-recursive call was inlined incorrectly, ipa_inline redirected the edge to the resolved node, leading to a cycle in the cgraph that wasn't exp