Re: [GOOGLE] Fix LIPO resolved node reference fixup

2014-10-27 Thread Xinliang David Li
ok. thanks, David On Mon, Oct 27, 2014 at 7:33 AM, Teresa Johnson wrote: > Here is the new patch that walks op looking for the reference to addr. > > Passes internal benchmarks and regression tests. Ok for google/4_9? > > Thanks, > Teresa > > 2014-10-27 Teresa Johnson > > Google ref

Re: [GOOGLE] Fix LIPO resolved node reference fixup

2014-10-27 Thread Teresa Johnson
Here is the new patch that walks op looking for the reference to addr. Passes internal benchmarks and regression tests. Ok for google/4_9? Thanks, Teresa 2014-10-27 Teresa Johnson Google ref b/18110567. * cgraphbuild.c (fixup_all_refs_1): New function. (fixup_all_refs

Re: [GOOGLE] Fix LIPO resolved node reference fixup

2014-10-24 Thread Teresa Johnson
On Fri, Oct 24, 2014 at 10:55 AM, Xinliang David Li wrote: > When orgin_addr == addr, is there a guarantee that this assert: > > gcc_assert (TREE_OPERAND (op,0) == addr); > > is always true? It should be, that is the assumption of the code that we are trying to enforce with the assert. Teresa

Re: [GOOGLE] Fix LIPO resolved node reference fixup

2014-10-24 Thread Xinliang David Li
When orgin_addr == addr, is there a guarantee that this assert: gcc_assert (TREE_OPERAND (op,0) == addr); is always true? David On Fri, Oct 24, 2014 at 10:21 AM, Teresa Johnson wrote: > This patch makes a fix to the reference fixups performed after LIPO > node resolution, to better handle t

[GOOGLE] Fix LIPO resolved node reference fixup

2014-10-24 Thread Teresa Johnson
This patch makes a fix to the reference fixups performed after LIPO node resolution, to better handle the case where we are updating the base address of a reference. Fixes google benchmark and passes regression tests. Ok for google/4_9? Thanks, Teresa 2014-10-24 Teresa Johnson Google