Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Christophe Lyon
On Mon, 10 Feb 2020 at 14:53, Jason Merrill wrote: > > On Mon, Feb 10, 2020 at 2:13 PM Christophe Lyon > wrote: >> >> On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: >> > >> > Here we were swallowing all the syntax errors by parsing tentatively, and >> > returning error_mark_node without ever

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Jason Merrill
On Mon, Feb 10, 2020 at 2:13 PM Christophe Lyon wrote: > On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: > > > > Here we were swallowing all the syntax errors by parsing tentatively, and > > returning error_mark_node without ever actually giving an error. Fixed > by > > using save_tokens/roll

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Christophe Lyon
On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: > > Here we were swallowing all the syntax errors by parsing tentatively, and > returning error_mark_node without ever actually giving an error. Fixed by > using save_tokens/rollback_tokens instead. > > Tested x86_64-pc-linux-gnu, applying to trun

[COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-07 Thread Jason Merrill
Here we were swallowing all the syntax errors by parsing tentatively, and returning error_mark_node without ever actually giving an error. Fixed by using save_tokens/rollback_tokens instead. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/92517 * parser.c (cp_parser_constra