Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-07 Thread Aldy Hernandez via Gcc-patches
On Wed, Oct 5, 2022 at 12:14 PM Aldy Hernandez wrote: > However... I don't think I have the stomach to overhaul the allocators > this late in the release. For this release I may opt to put the > nonzero mask back in a tree, but have it always be set. The NULL == > -1 shortcut was very error pro

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-05 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 4, 2022 at 5:42 PM Andrew MacLeod wrote: > > > On 10/4/22 11:14, Aldy Hernandez wrote: > > On Tue, Oct 4, 2022 at 4:34 PM Richard Biener > > wrote: > >> > >> > >>> Am 04.10.2022 um 16:30 schrieb Aldy Hernandez : > >>> > >>> On Tue, Oct 4, 2022 at 3:27 PM Andrew MacLeod > >>> wrote:

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Andrew MacLeod via Gcc-patches
On 10/4/22 11:14, Aldy Hernandez wrote: On Tue, Oct 4, 2022 at 4:34 PM Richard Biener wrote: Am 04.10.2022 um 16:30 schrieb Aldy Hernandez : On Tue, Oct 4, 2022 at 3:27 PM Andrew MacLeod wrote: On 10/4/22 08:13, Aldy Hernandez via Gcc-patches wrote: On Tue, Oct 4, 2022, 13:28 Aldy H

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 4, 2022 at 4:34 PM Richard Biener wrote: > > > > > Am 04.10.2022 um 16:30 schrieb Aldy Hernandez : > > > > On Tue, Oct 4, 2022 at 3:27 PM Andrew MacLeod wrote: > >> > >> > >>> On 10/4/22 08:13, Aldy Hernandez via Gcc-patches wrote: > On Tue, Oct 4, 2022, 13:28 Aldy Hernandez wr

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Richard Biener via Gcc-patches
> Am 04.10.2022 um 16:30 schrieb Aldy Hernandez : > > On Tue, Oct 4, 2022 at 3:27 PM Andrew MacLeod wrote: >> >> >>> On 10/4/22 08:13, Aldy Hernandez via Gcc-patches wrote: On Tue, Oct 4, 2022, 13:28 Aldy Hernandez wrote: >>> On Tue, Oct 4, 2022 at 9:55 AM Richard Biener w

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 4, 2022 at 3:27 PM Andrew MacLeod wrote: > > > On 10/4/22 08:13, Aldy Hernandez via Gcc-patches wrote: > > On Tue, Oct 4, 2022, 13:28 Aldy Hernandez wrote: > > > >> On Tue, Oct 4, 2022 at 9:55 AM Richard Biener > >> wrote: > >>> > >>> Am 04.10.2022 um 09:36 schrieb Aldy Hernandez via

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Andrew MacLeod via Gcc-patches
On 10/4/22 08:13, Aldy Hernandez via Gcc-patches wrote: On Tue, Oct 4, 2022, 13:28 Aldy Hernandez wrote: On Tue, Oct 4, 2022 at 9:55 AM Richard Biener wrote: Am 04.10.2022 um 09:36 schrieb Aldy Hernandez via Gcc-patches < gcc-patches@gcc.gnu.org>: The reason the nonzero mask was kept i

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 4, 2022, 13:28 Aldy Hernandez wrote: > On Tue, Oct 4, 2022 at 9:55 AM Richard Biener > wrote: > > > > > > Am 04.10.2022 um 09:36 schrieb Aldy Hernandez via Gcc-patches < > gcc-patches@gcc.gnu.org>: > > > > > > The reason the nonzero mask was kept in a tree was basically inertia, > >

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 4, 2022 at 9:55 AM Richard Biener wrote: > > > Am 04.10.2022 um 09:36 schrieb Aldy Hernandez via Gcc-patches > : > > > > The reason the nonzero mask was kept in a tree was basically inertia, > > as everything in irange is a tree. However, there's no need to keep > > it in a tree, as

Re: [COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Richard Biener via Gcc-patches
Am 04.10.2022 um 09:36 schrieb Aldy Hernandez via Gcc-patches : > > The reason the nonzero mask was kept in a tree was basically inertia, > as everything in irange is a tree. However, there's no need to keep > it in a tree, as the conversions to and from wide ints are very > annoying. That,

[COMMITTED] Convert nonzero mask in irange to wide_int.

2022-10-04 Thread Aldy Hernandez via Gcc-patches
The reason the nonzero mask was kept in a tree was basically inertia, as everything in irange is a tree. However, there's no need to keep it in a tree, as the conversions to and from wide ints are very annoying. That, plus special casing NULL masks to be -1 is prone to error. I have not only rew