Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-16 Thread Jeff Law
On 10/16/14 11:20, Marek Polacek wrote: On Wed, Oct 15, 2014 at 09:46:20PM +, Joseph S. Myers wrote: On Wed, 15 Oct 2014, Marek Polacek wrote: We've got a complaint that the "dereferencing pointer to incomplete type" error is printed for all occurrences of the incomplete type, which is too

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-16 Thread Marek Polacek
On Wed, Oct 15, 2014 at 11:52:59PM +0200, Jakub Jelinek wrote: > On Wed, Oct 15, 2014 at 03:48:20PM -0600, Jeff Law wrote: > > Isn't slamming error_mark_node well established at this point? I fact I > > recall seeing it documented to be used in this kind of way to prevent future > > errors. > > I

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-16 Thread Marek Polacek
On Wed, Oct 15, 2014 at 09:46:20PM +, Joseph S. Myers wrote: > On Wed, 15 Oct 2014, Marek Polacek wrote: > > > We've got a complaint that the "dereferencing pointer to incomplete > > type" error is printed for all occurrences of the incomplete type, > > which is too verbose. Also it'd be nice

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-15 Thread Joseph S. Myers
On Wed, 15 Oct 2014, Jeff Law wrote: > On 10/15/14 15:46, Joseph S. Myers wrote: > > On Wed, 15 Oct 2014, Marek Polacek wrote: > > > > > We've got a complaint that the "dereferencing pointer to incomplete > > > type" error is printed for all occurrences of the incomplete type, > > > which is too

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-15 Thread Jakub Jelinek
On Wed, Oct 15, 2014 at 03:48:20PM -0600, Jeff Law wrote: > On 10/15/14 15:46, Joseph S. Myers wrote: > >On Wed, 15 Oct 2014, Marek Polacek wrote: > > > >>We've got a complaint that the "dereferencing pointer to incomplete > >>type" error is printed for all occurrences of the incomplete type, > >>w

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-15 Thread Jeff Law
On 10/15/14 15:46, Joseph S. Myers wrote: On Wed, 15 Oct 2014, Marek Polacek wrote: We've got a complaint that the "dereferencing pointer to incomplete type" error is printed for all occurrences of the incomplete type, which is too verbose. Also it'd be nicer to print the type as well. This pa

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-15 Thread Joseph S. Myers
On Wed, 15 Oct 2014, Marek Polacek wrote: > We've got a complaint that the "dereferencing pointer to incomplete > type" error is printed for all occurrences of the incomplete type, > which is too verbose. Also it'd be nicer to print the type as well. > This patch fixes this; if we find an incompl

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-15 Thread Jeff Law
On 10/15/14 11:22, Marek Polacek wrote: We've got a complaint that the "dereferencing pointer to incomplete type" error is printed for all occurrences of the incomplete type, which is too verbose. Also it'd be nicer to print the type as well. This patch fixes this; if we find an incomplete type,

[C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-15 Thread Marek Polacek
We've got a complaint that the "dereferencing pointer to incomplete type" error is printed for all occurrences of the incomplete type, which is too verbose. Also it'd be nicer to print the type as well. This patch fixes this; if we find an incomplete type, mark it with error node, then we don't pr