Re: [C/C++ PATCH] shift with negative or too big count warning (PR c/48418)

2013-01-09 Thread Jason Merrill
The C++ change is OK. Jason

Re: [C/C++ PATCH] shift with negative or too big count warning (PR c/48418)

2013-01-08 Thread Joseph S. Myers
On Tue, 8 Jan 2013, Jakub Jelinek wrote: > Hi! > > As discussed in the PR, on the following testcase we've regressed with the > introduction of c_fully_fold, when the C FE normally warns the argument > isn't folded yet. Fixed by also warning in c_fully_fold_internal, if before > that function th

[C/C++ PATCH] shift with negative or too big count warning (PR c/48418)

2013-01-08 Thread Jakub Jelinek
Hi! As discussed in the PR, on the following testcase we've regressed with the introduction of c_fully_fold, when the C FE normally warns the argument isn't folded yet. Fixed by also warning in c_fully_fold_internal, if before that function the shift count wasn't INTEGER_CST and after it it is.