Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-05 Thread Jason Merrill
On 6/5/19 2:09 PM, Paolo Carlini wrote: Hi, On 05/06/19 19:45, Jason Merrill wrote: On 6/4/19 11:57 AM, Paolo Carlini wrote: Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "frie

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-05 Thread Paolo Carlini
Hi, On 05/06/19 19:45, Jason Merrill wrote: On 6/4/19 11:57 AM, Paolo Carlini wrote: Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "friends of their class"); Wouldn't it be be

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-05 Thread Jason Merrill
On 6/4/19 11:57 AM, Paolo Carlini wrote: Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "friends of their class"); Wouldn't it be better to use the location of "friend" in this d

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-04 Thread Paolo Carlini
Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "friends of their class"); Wouldn't it be better to use the location of "friend" in this diagnostic? Yes, however doing that fully

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-04 Thread Jason Merrill
On 6/4/19 10:31 AM, Paolo Carlini wrote: + permerror (loc, "member functions are implicitly " +"friends of their class"); Wouldn't it be better to use the location of "friend" in this diagnostic? The rest of the patch is OK. Jason

[C++ Patch] Use declarator->id_loc in three additional places

2019-06-04 Thread Paolo Carlini
Hi, tested x86_64-linux, as usual. Thanks, Paolo. /// /cp 2019-06-04 Paolo Carlini * decl.c (grokdeclarator): Use declarator->id_loc in three additional places. /testsuite 2019-06-04 Paolo Carlini * g++.dg/concepts/pr60573.C: Test locations