Re: [C++ Patch] PR 65340

2015-04-16 Thread Jason Merrill
OK, thanks. Jason

Re: [C++ Patch] PR 65340

2015-04-16 Thread Paolo Carlini
Hi again, On 04/15/2015 03:31 AM, Jason Merrill wrote: There are various places in the compiler that error and continue if tf_error is set, but return error_mark_node immediately if not; it seems reasonable to follow that pattern in the places that don't currently check the return value. Thus

Re: [C++ Patch] PR 65340

2015-04-15 Thread Paolo Carlini
Hi, On 04/15/2015 03:31 AM, Jason Merrill wrote: Agreed, let's defer this until stage 1. I note that it's now stage 1. :) There are various places in the compiler that error and continue if tf_error is set, but return error_mark_node immediately if not; it seems reasonable to follow that pa

Re: [C++ Patch] PR 65340

2015-04-14 Thread Jason Merrill
On 03/17/2015 10:15 PM, Jason Merrill wrote: On 03/17/2015 10:03 PM, Paolo Carlini wrote: On 03/18/2015 01:11 AM, Jason Merrill wrote: Are there other places that still need to pass complain to mark_used? Well, if we are talking about functions getting a tsubst_flags_t and *not* passing it d

Re: [C++ Patch] PR 65340

2015-03-17 Thread Jason Merrill
On 03/17/2015 10:03 PM, Paolo Carlini wrote: Hi, On 03/18/2015 01:11 AM, Jason Merrill wrote: On 03/17/2015 01:09 PM, Paolo Carlini wrote: - require_deduced_type (decl); + if (complain & tf_error) +require_deduced_type (decl); I think we want to return false if there's a problem here s

Re: [C++ Patch] PR 65340

2015-03-17 Thread Paolo Carlini
Hi, On 03/18/2015 01:11 AM, Jason Merrill wrote: On 03/17/2015 01:09 PM, Paolo Carlini wrote: - require_deduced_type (decl); + if (complain & tf_error) +require_deduced_type (decl); I think we want to return false if there's a problem here so that we don't just silently accept this in

Re: [C++ Patch] PR 65340

2015-03-17 Thread Jason Merrill
On 03/17/2015 01:09 PM, Paolo Carlini wrote: - require_deduced_type (decl); + if (complain & tf_error) +require_deduced_type (decl); I think we want to return false if there's a problem here so that we don't just silently accept this in SFINAE context. So probably we want to replace th

[C++ Patch] PR 65340

2015-03-17 Thread Paolo Carlini
Hi, this minor [5 Regression], an ICE on invalid, seems just matter of passing the tsubst_flags_t argument from build_over_call to mark_used and then guarding require_deduced_type in the latter. Tested x86_64-linux. Thanks, Paolo. / 2015-03-17 Paolo Carlini