Re: [C++ Patch] PR 58584

2013-10-03 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 58584

2013-10-03 Thread Paolo Carlini
Hi, On 10/03/2013 04:02 PM, Jason Merrill wrote: On 10/02/2013 09:02 PM, Paolo Carlini wrote: - save_template_attributes (&attributes, decl); + if (attributes != error_mark_node) +save_template_attributes (&attributes, decl); I'd rather make save_template_attributes handle error

Re: [C++ Patch] PR 58584

2013-10-03 Thread Jason Merrill
On 10/02/2013 09:02 PM, Paolo Carlini wrote: - save_template_attributes (&attributes, decl); + if (attributes != error_mark_node) + save_template_attributes (&attributes, decl); I'd rather make save_template_attributes handle error_mark_node appropriately. + if (attributes

[C++ Patch] PR 58584

2013-10-02 Thread Paolo Carlini
Hi, to avoid these ICE on invalid with C++11 alignas, we can simply avoid calling save_template_attributes and cp_check_const_attributes when something went wrong and attributes is error_mark_node. The parser bit just tidies the diagnostic, ie, avoids redundant messages about semicolons, etc