Re: [C++ Patch] Fixes for duplicate warnings regressions [1/2]

2013-11-26 Thread Paolo Carlini
Hi, On 11/25/2013 10:47 PM, Jason Merrill wrote: On 11/25/2013 05:02 AM, Paolo Carlini wrote: because then we don't warn *at all*. The reason being that with the *first* cp_convert we end up calling c_common_truthvalue_conversion with c_inhibit_evaluation_warnings bumped. The bumping happens in

Re: [C++ Patch] Fixes for duplicate warnings regressions [1/2]

2013-11-25 Thread Jason Merrill
On 11/25/2013 05:02 AM, Paolo Carlini wrote: because then we don't warn *at all*. The reason being that with the *first* cp_convert we end up calling c_common_truthvalue_conversion with c_inhibit_evaluation_warnings bumped. The bumping happens in cp_truthvalue_conversion. A mess, yes. Perhaps c

Re: [C++ Patch] Fixes for duplicate warnings regressions [1/2]

2013-11-25 Thread Paolo Carlini
... evidently I attached the wrong p ;) This should be right one. Paolo. Index: c-common.c === --- c-common.c (revision 205343) +++ c-common.c (working copy) @@ -4579,10 +4579,11 @@ c_common_truthvalue_conversion (location_t locati

Re: [C++ Patch] Fixes for duplicate warnings regressions [1/2]

2013-11-25 Thread Paolo Carlini
On 11/23/2013 08:12 PM, Jason Merrill wrote: On 11/10/2013 05:26 AM, Paolo Carlini wrote: this is the issue with -Waddress caused by the fix for c++/56930. I'm handling it as already described, that is by adding a bool parameter to c_common_truthvalue_conversion. Why not handle this by making

Re: [C++ Patch] Fixes for duplicate warnings regressions [1/2]

2013-11-23 Thread Jason Merrill
On 11/10/2013 05:26 AM, Paolo Carlini wrote: this is the issue with -Waddress caused by the fix for c++/56930. I'm handling it as already described, that is by adding a bool parameter to c_common_truthvalue_conversion. Why not handle this by making that warning respect c_inhibit_evaluation_war

[C++ Patch] Fixes for duplicate warnings regressions [1/2]

2013-11-10 Thread Paolo Carlini
Hi, this is the issue with -Waddress caused by the fix for c++/56930. I'm handling it as already described, that is by adding a bool parameter to c_common_truthvalue_conversion. Tested x86_64-linux. Thanks! Paolo. // /c-family 2013-11-11 Paolo Carlini * c-com