Re: [C++ Patch] Fix two grokdeclarator locations

2018-11-14 Thread Jason Merrill
OK. On Wed, Nov 14, 2018 at 4:26 AM Paolo Carlini wrote: > > Hi, > > On 14/11/18 01:30, Jason Merrill wrote: > > On 11/12/18 6:39 AM, Paolo Carlini wrote: > >> Hi again, > >> > >> On 08/11/18 10:26, Paolo Carlini wrote: > >>> Hi, > >>> > >>> two additional grokdeclarator locations that we can easi

Re: [C++ Patch] Fix two grokdeclarator locations

2018-11-14 Thread Paolo Carlini
Hi, On 14/11/18 01:30, Jason Merrill wrote: On 11/12/18 6:39 AM, Paolo Carlini wrote: Hi again, On 08/11/18 10:26, Paolo Carlini wrote: Hi, two additional grokdeclarator locations that we can easily fix by using declarator->id_loc. Slightly more interesting, testing revealed a latent issue

Re: [C++ Patch] Fix two grokdeclarator locations

2018-11-13 Thread Jason Merrill
On 11/12/18 6:39 AM, Paolo Carlini wrote: Hi again, On 08/11/18 10:26, Paolo Carlini wrote: Hi, two additional grokdeclarator locations that we can easily fix by using declarator->id_loc. Slightly more interesting, testing revealed a latent issue in the make_id_declarator uses: cp_parser_me

Re: [C++ Patch] Fix two grokdeclarator locations

2018-11-12 Thread Paolo Carlini
Hi again, On 08/11/18 10:26, Paolo Carlini wrote: Hi, two additional grokdeclarator locations that we can easily fix by using declarator->id_loc. Slightly more interesting, testing revealed a latent issue in the make_id_declarator uses: cp_parser_member_declaration wasn't setting declarator-

[C++ Patch] Fix two grokdeclarator locations

2018-11-08 Thread Paolo Carlini
Hi, two additional grokdeclarator locations that we can easily fix by using declarator->id_loc. Slightly more interesting, testing revealed a latent issue in the make_id_declarator uses: cp_parser_member_declaration wasn't setting declarator->id_loc, thus I decided to add a location_t paramet