Re: [C++ PATCH] Using decls

2019-05-21 Thread Nathan Sidwell
On 5/21/19 10:43 AM, Marek Polacek wrote: Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: -/* Process a local-scope or namespace-scope using declaration. SCOPE +/* Process a local-scope or namespace-scope using declaration. + FIX

Re: [C++ PATCH] Using decls

2019-05-21 Thread Nathan Sidwell
On 5/21/19 10:43 AM, Marek Polacek wrote: Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: -/* Process a local-scope or namespace-scope using declaration. SCOPE +/* Process a local-scope or namespace-scope using declaration. + FIX

Re: [C++ PATCH] Using decls

2019-05-21 Thread Marek Polacek
Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: > -/* Process a local-scope or namespace-scope using declaration. SCOPE > +/* Process a local-scope or namespace-scope using declaration. > + FIXME This ain't look right. You meant t

[C++ PATCH] Using decls

2019-05-21 Thread Nathan Sidwell
This patch reimplements using-decl handling. It removes the double lookup of the target name, and commonizes the local- and namespace- scope handling into a single function. Applying to trunk. nathan -- Nathan Sidwell 2019-05-21 Nathan Sidwell gcc/cp/ * name-lookup.h (struct cp_binding_

[C++ PATCH] using decls

2017-05-23 Thread Nathan Sidwell
This patch addresses namespace and local scope using declarations. Unlike the using directive case, we already had separate workers for these, they just needed a bit of cleanup to use the new iterator and make them ready for the pushdecl change that's coming. I renamed them consistently with t