Re: [C++ PATCH] Implement P0961

2018-04-05 Thread Jason Merrill
OK, thanks. On Thu, Apr 5, 2018 at 10:06 AM, Ville Voutilainen wrote: > On 5 April 2018 at 16:37, Jason Merrill wrote: >> On Wed, Apr 4, 2018 at 6:26 PM, Ville Voutilainen >> wrote: >>> + tree parm = TREE_VEC_ELT (TREE_VALUE (tparms), 0); >> >> I think you want to use INNERMOST_TEMPLATE_PARMS

Re: [C++ PATCH] Implement P0961

2018-04-05 Thread Ville Voutilainen
On 5 April 2018 at 16:37, Jason Merrill wrote: > On Wed, Apr 4, 2018 at 6:26 PM, Ville Voutilainen > wrote: >> + tree parm = TREE_VEC_ELT (TREE_VALUE (tparms), 0); > > I think you want to use INNERMOST_TEMPLATE_PARMS here rather than > TREE_VALUE directly. > > Please also add a comment quoting

Re: [C++ PATCH] Implement P0961

2018-04-05 Thread Jason Merrill
On Wed, Apr 4, 2018 at 6:26 PM, Ville Voutilainen wrote: > + tree parm = TREE_VEC_ELT (TREE_VALUE (tparms), 0); I think you want to use INNERMOST_TEMPLATE_PARMS here rather than TREE_VALUE directly. Please also add a comment quoting the rule you're implementing. Jason

[C++ PATCH] Implement P0961

2018-04-04 Thread Ville Voutilainen
Tested on Linux-PPC64. 2018-04-05 Ville Voutilainen gcc/cp Implement P0961 * decl.c (get_tuple_decomp_init): Check the templatedness of a member get. testsuite/ Implement P0961 * g++.dg/cpp1z/decomp10.C: Adjust. * g++.dg/cpp1z/decomp37.C: New. diff --git a/gc