Re: [C++ PATCH] Fix a recent regression (PR c++/90947)

2019-10-30 Thread Jason Merrill
On 10/30/19 7:29 PM, Jakub Jelinek wrote: On Tue, Oct 29, 2019 at 04:26:14PM -0400, Jason Merrill wrote: I think type_initializer_zero_p should return false if CLASSTYPE_NON_AGGREGATE; we can't expect that value-initialization will have the intended effect in that case. That indeed works for t

[C++ PATCH] Fix a recent regression (PR c++/90947)

2019-10-30 Thread Jakub Jelinek
On Tue, Oct 29, 2019 at 04:26:14PM -0400, Jason Merrill wrote: > I think type_initializer_zero_p should return false if > CLASSTYPE_NON_AGGREGATE; we can't expect that value-initialization will have > the intended effect in that case. That indeed works for this testcase and doesn't break anything