Re: [C++ PATCH] Fix PR58979

2013-11-04 Thread Jason Merrill
OK. Jason

Re: [C++ PATCH] Fix PR58979

2013-11-04 Thread Marek Polacek
On Mon, Nov 04, 2013 at 10:36:35AM -0500, Jason Merrill wrote: > On 11/04/2013 05:50 AM, Marek Polacek wrote: > > case RO_ARROW: > >+case RO_ARROW_STAR: > >error_at (loc, > > "invalid type argument of %<->%> (have %qT)", > > type); > > I think the diagnosti

Re: [C++ PATCH] Fix PR58979

2013-11-04 Thread Jason Merrill
On 11/04/2013 05:50 AM, Marek Polacek wrote: case RO_ARROW: +case RO_ARROW_STAR: error_at (loc, "invalid type argument of %<->%> (have %qT)", type); I think the diagnostic for RO_ARROW_STAR should say ->*, not just ->. Jason

[C++ PATCH] Fix PR58979

2013-11-04 Thread Marek Polacek
Even RO_ARROW_STAR can end up in invalid_indirection_error in invalid code, so handle that instead of ICEing later on. Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.8? 2013-11-04 Marek Polacek PR c++/58979 c-family/ * c-common.c (invalid_indirection_error): Handle