Re: [C++ PATCH] Fix PR 55418

2012-11-23 Thread Paolo Carlini
... thus we could also do the below, for example. Actually I probably like it a tad better ;) Paolo. Index: method.c === --- method.c(revision 193758) +++ method.c(working copy) @@ -1175,6 +1175,7 @@ synthe

Re: [C++ PATCH] Fix PR 55418

2012-11-23 Thread Paolo Carlini
Hi, On 11/23/2012 04:47 PM, Jason Merrill wrote: On 11/23/2012 10:46 AM, Jason Merrill wrote: On 11/22/2012 11:03 AM, Paolo Carlini wrote: initialized to true too), but Markus (and me ;) proposes anyway to initialize trivial_p to false, thus we should be fine (way below trivial_p is used again

Re: [C++ PATCH] Fix PR 55418

2012-11-23 Thread Jason Merrill
On 11/23/2012 10:46 AM, Jason Merrill wrote: On 11/22/2012 11:03 AM, Paolo Carlini wrote: initialized to true too), but Markus (and me ;) proposes anyway to initialize trivial_p to false, thus we should be fine (way below trivial_p is used again but only when deleted_p is false). It certainly

Re: [C++ PATCH] Fix PR 55418

2012-11-23 Thread Jason Merrill
On 11/22/2012 11:03 AM, Paolo Carlini wrote: initialized to true too), but Markus (and me ;) proposes anyway to initialize trivial_p to false, thus we should be fine (way below trivial_p is used again but only when deleted_p is false). It certainly can't hurt. Jason

Re: [C++ PATCH] Fix PR 55418

2012-11-22 Thread Paolo Carlini
Hi, On 11/22/2012 04:06 PM, Jakub Jelinek wrote: On Thu, Nov 22, 2012 at 02:28:18PM +0100, Paolo Carlini wrote: On 11/22/2012 01:06 PM, Markus Trippelsdorf wrote: The fix is trivial. I would appreciate if someone could commit this. I agree it qualifies as obvious and I mean to commit the patc

Re: [C++ PATCH] Fix PR 55418

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 02:28:18PM +0100, Paolo Carlini wrote: > On 11/22/2012 01:06 PM, Markus Trippelsdorf wrote: > >The fix is trivial. I would appreciate if someone could commit this. > I agree it qualifies as obvious and I mean to commit the patch on > your behalf before the end of the day if

Re: [C++ PATCH] Fix PR 55418

2012-11-22 Thread Paolo Carlini
Hi, On 11/22/2012 01:06 PM, Markus Trippelsdorf wrote: The fix is trivial. I would appreciate if someone could commit this. I agree it qualifies as obvious and I mean to commit the patch on your behalf before the end of the day if nobody objects. To be super-safe, I guess I will also run the t

[C++ PATCH] Fix PR 55418

2012-11-22 Thread Markus Trippelsdorf
Hi, Valgrind complains about an uninitialized variable in method.c (implicitly_declare_fn): ==19553== Conditional jump or move depends on uninitialised value(s) ==19553==at 0x63D248: implicitly_declare_fn(special_function_kind, tree_node*, bool, tree_node*, tree_node*) (method.c:1623) ==19