Re: [C++] template arg comparison

2020-05-15 Thread Nathan Sidwell
On 5/14/20 3:17 PM, Arseny Solokha wrote: Hi, - if (TREE_CODE (nt) == TREE_VEC) + if (TREE_CODE (nt) == TREE_VEC || TREE_CODE (nt) == TREE_VEC) Shouldn't there be if (TREE_CODE (ot) == TREE_VEC || TREE_CODE (nt) == TREE_VEC) + else if (TYPE_P (nt) || TYPE_P (nt)) And here: el

Re: [C++] template arg comparison

2020-05-14 Thread Arseny Solokha
Hi, > When fixing up the template specialization hasher I was confused by the > control flow through template_args_equal. This reorders the category > checking, so it is clearer as to what kind of node can reach which point. > > nathan > > 2020-05-13 Nathan Sidwell > > * pt.c (template_

[C++] template arg comparison

2020-05-13 Thread Nathan Sidwell
When fixing up the template specialization hasher I was confused by the control flow through template_args_equal. This reorders the category checking, so it is clearer as to what kind of node can reach which point. nathan -- Nathan Sidwell 2020-05-13 Nathan Sidwell * pt.c (template_args_