Re: [AArch64] fix missing Dwarf call frame information in the epilogue

2012-11-06 Thread Marcus Shawcroft
On 06/11/12 18:21, Richard Henderson wrote: On 2012-11-06 09:56, Yufeng Zhang wrote: 2012-11-06 Yufeng Zhang * config/aarch64/aarch64.c (aarch64_expand_prologue): For the load-pair with writeback instruction, replace aarch64_set_frame_expr with add_reg_note (REG_C

Re: [AArch64] fix missing Dwarf call frame information in the epilogue

2012-11-06 Thread Richard Henderson
On 2012-11-06 09:56, Yufeng Zhang wrote: > 2012-11-06 Yufeng Zhang > > * config/aarch64/aarch64.c (aarch64_expand_prologue): For the > load-pair with writeback instruction, replace > aarch64_set_frame_expr with add_reg_note (REG_CFA_ADJUST_CFA); > add new loc

Re: [AArch64] fix missing Dwarf call frame information in the epilogue

2012-11-06 Thread Yufeng Zhang
Hi, Many thanks for reviewing. Please find the updated patch. The explicit calls to gen_rtx_PLUS and GEN_INT have been replaced by plus_constant, and the call to aarch64_set_frame_expr has been replaced with add_reg_note (REG_CFA_ADJUST_CFA). I'll clean up other cases in aarch64.c in a sep

Re: [AArch64] fix missing Dwarf call frame information in the epilogue

2012-09-12 Thread Richard Henderson
On 09/12/2012 09:10 AM, Yufeng Zhang wrote: > aarch64_set_frame_expr (gen_rtx_SET > (Pmode, > stack_pointer_rtx, > -gen_rtx_PLUS (Pmode, stack_pointer_rtx, > +

[AArch64] fix missing Dwarf call frame information in the epilogue

2012-09-12 Thread Yufeng Zhang
This patch fixes a bug in the AArch64 epilogue expander which failed to generate consistent information of REG_FRAME_RELATED_EXPR reg notes in some cases; for instance, given the following C source code: int bar (unsigned int); int foo (void) { return bar (0xcafe); } --- CUT