Re: [5.0 Backport][AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-29 Thread Jiong Wang
Jiong Wang writes: > On 07/07/16 10:34, James Greenhalgh wrote: >> >> To make backporting easier, could you please write a very simple >> standalone test that exposes this bug, and submit this patch with just >> that simple test? I've already OKed the functional part of this patch, and >> I'm hap

[COMMITTED][AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-08 Thread Jiong Wang
On 07/07/16 10:34, James Greenhalgh wrote: To make backporting easier, could you please write a very simple standalone test that exposes this bug, and submit this patch with just that simple test? I've already OKed the functional part of this patch, and I'm happy to pre-approve a simple testcase

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread Jiong Wang
On 07/07/16 15:13, Christophe Lyon wrote: On 7 July 2016 at 14:54, Jiong Wang wrote: On 07/07/16 12:36, Christophe Lyon wrote: On 7 July 2016 at 11:16, Jiong Wang wrote: I was using dg-xfail-if, (the description is still using "marked as XFAIL"...), but later found it's actually broken u

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread Christophe Lyon
On 7 July 2016 at 14:54, Jiong Wang wrote: > > > On 07/07/16 12:36, Christophe Lyon wrote: >> >> On 7 July 2016 at 11:16, Jiong Wang wrote: >>> >>> >>> I was using dg-xfail-if, (the description is still using "marked as >>> XFAIL"...), >>> but later found it's actually broken under advsimd-intrin

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread Jiong Wang
On 07/07/16 12:36, Christophe Lyon wrote: On 7 July 2016 at 11:16, Jiong Wang wrote: I was using dg-xfail-if, (the description is still using "marked as XFAIL"...), but later found it's actually broken under advsimd-intrinsics, UNRESOLVEDs are given at the same time instead of clean XFAIL, I

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread Christophe Lyon
On 7 July 2016 at 11:16, Jiong Wang wrote: > On 06/07/16 16:55, Christophe Lyon wrote: >> >> On 6 July 2016 at 17:44, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> >>> On 06/07/16 16:29, James Greenhalgh wrote: On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: > > T

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread Christophe Lyon
On 7 July 2016 at 11:16, Jiong Wang wrote: > On 06/07/16 16:55, Christophe Lyon wrote: >> >> On 6 July 2016 at 17:44, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> >>> On 06/07/16 16:29, James Greenhalgh wrote: On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: > > T

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread James Greenhalgh
On Thu, Jul 07, 2016 at 10:16:31AM +0100, Jiong Wang wrote: > I was using dg-xfail-if, (the description is still using "marked as > XFAIL"...), > but later found it's actually broken under advsimd-intrinsics, > UNRESOLVEDs are > given at the same time instead of clean XFAIL, I suspect those dg-do-w

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-07 Thread Jiong Wang
On 06/07/16 16:55, Christophe Lyon wrote: On 6 July 2016 at 17:44, Kyrill Tkachov wrote: Hi all, On 06/07/16 16:29, James Greenhalgh wrote: On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: The current vmaxnm/vminnm float intrinsics are implemented using __builtin_aarch64_smax/min

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-06 Thread Christophe Lyon
On 6 July 2016 at 17:44, Kyrill Tkachov wrote: > Hi all, > > > On 06/07/16 16:29, James Greenhalgh wrote: >> >> On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: >>> >>> The current vmaxnm/vminnm float intrinsics are implemented using >>> __builtin_aarch64_smax/min which are mapping to

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-06 Thread Kyrill Tkachov
Hi all, On 06/07/16 16:29, James Greenhalgh wrote: On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: The current vmaxnm/vminnm float intrinsics are implemented using __builtin_aarch64_smax/min which are mapping to backend patterns using smin/smax rtl operators. However as documented

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-06 Thread Christophe Lyon
On 6 July 2016 at 17:29, James Greenhalgh wrote: > On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: >> The current vmaxnm/vminnm float intrinsics are implemented using >> __builtin_aarch64_smax/min which are mapping to backend patterns >> using smin/smax rtl operators. However as docu

Re: [AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-06 Thread James Greenhalgh
On Wed, Jul 06, 2016 at 02:11:51PM +0100, Jiong Wang wrote: > The current vmaxnm/vminnm float intrinsics are implemented using > __builtin_aarch64_smax/min which are mapping to backend patterns > using smin/smax rtl operators. However as documented in rtl.def > > "Further, if both operands are

[AArch64] Fix simd intrinsics bug on float vminnm/vmaxnm

2016-07-06 Thread Jiong Wang
The current vmaxnm/vminnm float intrinsics are implemented using __builtin_aarch64_smax/min which are mapping to backend patterns using smin/smax rtl operators. However as documented in rtl.def "Further, if both operands are zeros, or if either operand is NaN, then it is unspecified which o