Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-04-01 Thread Evandro Menezes
On 04/01/16 09:06, James Greenhalgh wrote: On Fri, Apr 01, 2016 at 02:47:05PM +0100, Wilco Dijkstra wrote: Evandro Menezes wrote: Ping^1 I haven't seen a newer version that incorporates my feedback. To recap what I'd like to see is a more general way to select approximations based on mode. I d

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-04-01 Thread Evandro Menezes
On 04/01/16 08:47, Wilco Dijkstra wrote: Evandro Menezes wrote: Ping^1 I haven't seen a newer version that incorporates my feedback. To recap what I'd like to see is a more general way to select approximations based on mode. I don't believe that looking at the inner mode works in general, and i

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-04-01 Thread James Greenhalgh
On Fri, Apr 01, 2016 at 02:47:05PM +0100, Wilco Dijkstra wrote: > Evandro Menezes wrote: > > > > Ping^1 > > I haven't seen a newer version that incorporates my feedback. To recap what > I'd like to see is a more general way to select approximations based on mode. > I don't believe that looking at

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-04-01 Thread Wilco Dijkstra
Evandro Menezes wrote: > > Ping^1 I haven't seen a newer version that incorporates my feedback. To recap what I'd like to see is a more general way to select approximations based on mode. I don't believe that looking at the inner mode works in general, and it doesn't make sense to add internal tu

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-03-31 Thread Evandro Menezes
On 03/18/16 18:00, Evandro Menezes wrote: On 03/18/16 17:20, Wilco Dijkstra wrote: Evandro Menezes wrote: On 03/18/16 10:21, Wilco Dijkstra wrote: Hi Evandro, For example, though this approximation is improves the performance noticeably for DF on A57, for SF, not so much, if at all. I'm sti

[AArch64] Add precision choices for the reciprocal square root approximation

2016-03-19 Thread Evandro Menezes
Add precision choices for the reciprocal square root approximation Allow a target to prefer such operation depending on the FP precision. gcc/ * config/aarch64/aarch64-protos.h (AARCH64_EXTRA_TUNE_APPROX_RSQRT): New macro. * config/a

[AArch64] Add precision choices for the reciprocal square root approximation

2016-03-19 Thread Evandro Menezes
Add precision choices for the reciprocal square root approximation Allow a target to prefer such operation depending on the FP precision. gcc/ * config/aarch64/aarch64-protos.h (AARCH64_EXTRA_TUNE_APPROX_RSQRT): New macro. * config/a

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-03-19 Thread Wilco Dijkstra
Hi Evandro, > For example, though this approximation is improves the performance > noticeably for DF on A57, for SF, not so much, if at all. I'm still skeptical that you ever can get any gain on scalars. I bet the only gain is on 4x vectorized floats. So what I would like to see is this impleme

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-03-18 Thread Evandro Menezes
On 03/18/16 10:21, Wilco Dijkstra wrote: Hi Evandro, For example, though this approximation is improves the performance noticeably for DF on A57, for SF, not so much, if at all. I'm still skeptical that you ever can get any gain on scalars. I bet the only gain is on 4x vectorized floats. I

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-03-18 Thread Wilco Dijkstra
Evandro Menezes wrote: > On 03/18/16 10:21, Wilco Dijkstra wrote: > > Hi Evandro, > > > >> For example, though this approximation is improves the performance > >> noticeably for DF on A57, for SF, not so much, if at all. > > I'm still skeptical that you ever can get any gain on scalars. I bet the

Re: [AArch64] Add precision choices for the reciprocal square root approximation

2016-03-18 Thread Evandro Menezes
On 03/18/16 17:20, Wilco Dijkstra wrote: Evandro Menezes wrote: On 03/18/16 10:21, Wilco Dijkstra wrote: Hi Evandro, For example, though this approximation is improves the performance noticeably for DF on A57, for SF, not so much, if at all. I'm still skeptical that you ever can get any gai