Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-21 Thread Richard Earnshaw
On 18/04/15 19:17, Maxim Kuvyrkov wrote: >> On Apr 18, 2015, at 8:21 PM, Richard Earnshaw >> wrote: >> >> On 18/04/15 16:13, Jakub Jelinek wrote: >>> On Sat, Apr 18, 2015 at 03:07:16PM +0100, Richard Earnshaw wrote: You need to ensure that your scratch register cannot overlap op1, since

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-18 Thread Maxim Kuvyrkov
> On Apr 18, 2015, at 8:21 PM, Richard Earnshaw > wrote: > > On 18/04/15 16:13, Jakub Jelinek wrote: >> On Sat, Apr 18, 2015 at 03:07:16PM +0100, Richard Earnshaw wrote: >>> You need to ensure that your scratch register cannot overlap op1, since >>> the scratch is written before op1 is read. >>

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-18 Thread Richard Earnshaw
On 18/04/15 16:13, Jakub Jelinek wrote: > On Sat, Apr 18, 2015 at 03:07:16PM +0100, Richard Earnshaw wrote: >> You need to ensure that your scratch register cannot overlap op1, since >> the scratch is written before op1 is read. > > - (clobber (match_scratch:QI 3 "=X,w,X"))] > + (clobber (matc

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-18 Thread Jakub Jelinek
On Sat, Apr 18, 2015 at 03:07:16PM +0100, Richard Earnshaw wrote: > You need to ensure that your scratch register cannot overlap op1, since > the scratch is written before op1 is read. - (clobber (match_scratch:QI 3 "=X,w,X"))] + (clobber (match_scratch:QI 3 "=X,&w,X"))] incremental diff shou

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-18 Thread Richard Earnshaw
On 16/04/15 00:00, Kugan wrote: > > > On 16/04/15 08:32, Jakub Jelinek wrote: >> On Thu, Apr 16, 2015 at 08:27:24AM +1000, Kugan wrote: >>> +if ( == LSHIFTRT) >>> + { >>> +emit_insn (gen_aarch64_lshr_sisd_or_int_3 (operands[0], >>> operands[1], operands[2])); >> >> That is way t

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Kugan
On 16/04/15 08:32, Jakub Jelinek wrote: > On Thu, Apr 16, 2015 at 08:27:24AM +1000, Kugan wrote: >> +if ( == LSHIFTRT) >> + { >> +emit_insn (gen_aarch64_lshr_sisd_or_int_3 (operands[0], >> operands[1], operands[2])); > > That is way too long line, please wrap it. > >> +

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Jakub Jelinek
On Thu, Apr 16, 2015 at 08:27:24AM +1000, Kugan wrote: > +if ( == LSHIFTRT) > + { > +emit_insn (gen_aarch64_lshr_sisd_or_int_3 (operands[0], > operands[1], operands[2])); That is way too long line, please wrap it. > +DONE; > + } >} > ) > > @@ -3361,11 +3367,1

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Kugan
On 15/04/15 22:32, Jakub Jelinek wrote: > On Wed, Apr 15, 2015 at 01:18:36PM +0100, Richard Earnshaw wrote: >> On 14/04/15 22:41, Kugan wrote: >>> This patch uses clobber with match_scratch instead of earlyclobber for >>> aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in >>> selectin

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Kugan
On 15/04/15 21:59, Maxim Kuvyrkov wrote: >> On Apr 15, 2015, at 12:41 AM, Kugan >> wrote: >> >> This patch uses clobber with match_scratch instead of earlyclobber for >> aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in >> selecting suitable register, as discussed in >> http://thread

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Jakub Jelinek
On Wed, Apr 15, 2015 at 01:18:36PM +0100, Richard Earnshaw wrote: > On 14/04/15 22:41, Kugan wrote: > >This patch uses clobber with match_scratch instead of earlyclobber for > >aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in > >selecting suitable register, as discussed in > >http://t

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Richard Earnshaw
On 14/04/15 22:41, Kugan wrote: This patch uses clobber with match_scratch instead of earlyclobber for aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in selecting suitable register, as discussed in http://thread.gmane.org/gmane.comp.gcc.patches/336162 and reported in https://gcc.gnu.

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-15 Thread Maxim Kuvyrkov
> On Apr 15, 2015, at 12:41 AM, Kugan wrote: > > This patch uses clobber with match_scratch instead of earlyclobber for > aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in > selecting suitable register, as discussed in > http://thread.gmane.org/gmane.comp.gcc.patches/336162 and repor

[AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-14 Thread Kugan
This patch uses clobber with match_scratch instead of earlyclobber for aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in selecting suitable register, as discussed in http://thread.gmane.org/gmane.comp.gcc.patches/336162 and reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65139