Re: [5/8] Tweak bitfield alignment handling

2012-11-20 Thread Eric Botcazou
> gcc/ > * stor-layout.c (bit_field_mode_iterator::next_mode): Fix signedness. This looks fine to me. -- Eric Botcazou

Re: [5/8] Tweak bitfield alignment handling

2012-11-20 Thread Richard Sandiford
Richard Sandiford writes: > Mikael Pettersson writes: >> John David Anglin writes: >> > On Sun, 18 Nov 2012, Richard Sandiford wrote: >> > >> > >HOST_WIDE_INT start = bitpos_ - (bitpos_ % unit); >> > >if (bitregion_start_ && start < bitregion_start_) >> > > break; >>

Re: [5/8] Tweak bitfield alignment handling

2012-11-20 Thread Richard Sandiford
Mikael Pettersson writes: > John David Anglin writes: > > On Sun, 18 Nov 2012, Richard Sandiford wrote: > > > > >HOST_WIDE_INT start = bitpos_ - (bitpos_ % unit); > > >if (bitregion_start_ && start < bitregion_start_) > > > break; > > > - if (bitregion_end_ &&

Re: [5/8] Tweak bitfield alignment handling

2012-11-20 Thread Mikael Pettersson
John David Anglin writes: > On Sun, 18 Nov 2012, Richard Sandiford wrote: > > >HOST_WIDE_INT start = bitpos_ - (bitpos_ % unit); > >if (bitregion_start_ && start < bitregion_start_) > >break; > > - if (bitregion_end_ && start + unit > bitregion_end_ + 1) > > +

Re: [5/8] Tweak bitfield alignment handling

2012-11-19 Thread John David Anglin
On Sun, 18 Nov 2012, Richard Sandiford wrote: >HOST_WIDE_INT start = bitpos_ - (bitpos_ % unit); >if (bitregion_start_ && start < bitregion_start_) > break; > - if (bitregion_end_ && start + unit > bitregion_end_ + 1) > + if (start + unit > bitregion_end_ + 1) This

Re: [5/8] Tweak bitfield alignment handling

2012-11-18 Thread Richard Sandiford
Eric Botcazou writes: >> This patch replaces: >> >> /* Stop if the mode is wider than the alignment of the containing >> object. >> >> It is tempting to omit the following line unless STRICT_ALIGNMENT >> is true. But that is incorrect, since if the bitfield uses part >>

Re: [5/8] Tweak bitfield alignment handling

2012-11-13 Thread Eric Botcazou
> This patch replaces: > > /* Stop if the mode is wider than the alignment of the containing >object. > >It is tempting to omit the following line unless STRICT_ALIGNMENT >is true. But that is incorrect, since if the bitfield uses part >of 3 bytes and we use

[5/8] Tweak bitfield alignment handling

2012-11-03 Thread Richard Sandiford
This patch replaces: /* Stop if the mode is wider than the alignment of the containing object. It is tempting to omit the following line unless STRICT_ALIGNMENT is true. But that is incorrect, since if the bitfield uses part of 3 bytes and we use a 4-byt