Re: [4.7] Avoid global state in s390_handle_option

2011-03-23 Thread Joseph S. Myers
On Wed, 23 Mar 2011, Andreas Krebbel wrote: > Hi Joseph, > > sorry for the late reply to your patch. I would like to propose a few > changes as implemented with the attached patch: These seem reasonable to me. -- Joseph S. Myers jos...@codesourcery.com

Re: [4.7] Avoid global state in s390_handle_option

2011-03-23 Thread Andreas Krebbel
Hi Joseph, sorry for the late reply to your patch. I would like to propose a few changes as implemented with the attached patch: - The options mapped to an enum type seem to always need an initialization value. Otherwise there is a warning when compiling options.c: error: enum conversion i

[4.7] Avoid global state in s390_handle_option

2011-03-10 Thread Joseph S. Myers
This patch, for 4.7 and relative to a tree with applied, stops the S390 handle_option hook from using global state. S390 already had a processor enumeration, but not one suitable for direct use with Enum in the .opt file for handling -march