Re: [3/6] OpenMP 4.0 C++ FE support

2013-10-10 Thread Jason Merrill
On 10/10/2013 11:01 AM, Jakub Jelinek wrote: int inhibit_evaluation_warnings; + int omp_declare_target_attribute; Let's keep the comment you had on the variable, just put it on the member now. OK with that change. Jason

Re: [3/6] OpenMP 4.0 C++ FE support

2013-10-10 Thread Jakub Jelinek
On Wed, Oct 09, 2013 at 08:17:55PM -0400, Jason Merrill wrote: > Please add a comment explaining why an invisiref decl is handled specially. Ok. > >@@ -1345,6 +1384,30 @@ cplus_decl_attributes (tree *decl, tree > > || *decl == error_mark_node) > > return; > > > >+ /* Add implicit "omp

Re: [3/6] OpenMP 4.0 C++ FE support

2013-10-09 Thread Jason Merrill
On 10/08/2013 03:53 PM, Jakub Jelinek wrote: case OMP_CLAUSE_REDUCTION: - gcc_assert (!is_invisiref_parm (OMP_CLAUSE_DECL (stmt))); + if (is_invisiref_parm (OMP_CLAUSE_DECL (stmt))) + { + *walk_subtrees = 0; + if (OMP_CLAUSE_REDUCTION_INIT (stmt)) +