Re: [08/23] Add an alternative splay tree implementation

2021-01-05 Thread Richard Biener via Gcc-patches
On Mon, Jan 4, 2021 at 4:43 PM Richard Sandiford via Gcc-patches wrote: > > Andreas Schwab writes: > > On Jan 04 2021, Richard Sandiford wrote: > > > >> Andreas Schwab writes: > >>> That doesn't build with gcc 4.8: > >> > >> Which subversion are you using? > > > > This is 4.8.1. > > Hmm, OK. I

Re: [08/23] Add an alternative splay tree implementation

2021-01-04 Thread Richard Sandiford via Gcc-patches
Andreas Schwab writes: > On Jan 04 2021, Richard Sandiford wrote: > >> Andreas Schwab writes: >>> That doesn't build with gcc 4.8: >> >> Which subversion are you using? > > This is 4.8.1. Hmm, OK. I guess that raises the question whether “supporting GCC 4.8” means supporting every patchlevel, o

Re: [08/23] Add an alternative splay tree implementation

2021-01-04 Thread Jeff Law via Gcc-patches
On 12/16/20 5:29 PM, Richard Sandiford wrote: > Jeff Law writes: >> On 11/13/20 1:15 AM, Richard Sandiford via Gcc-patches wrote: >>> We already have two splay tree implementations: the old C one in >>> libiberty and a templated reimplementation of it in typed-splay-tree.h. >>> However, they ha

Re: [08/23] Add an alternative splay tree implementation

2021-01-04 Thread Andreas Schwab
On Jan 04 2021, Richard Sandiford wrote: > Andreas Schwab writes: >> That doesn't build with gcc 4.8: > > Which subversion are you using? This is 4.8.1. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for some

Re: [08/23] Add an alternative splay tree implementation

2021-01-04 Thread Richard Sandiford via Gcc-patches
Andreas Schwab writes: > That doesn't build with gcc 4.8: Which subversion are you using? It works for me with stock gcc 4.8.5, which is what I'd used to test the series for C++ compatiblity. Richard > > In file included from ../../gcc/splay-tree-utils.h:491:0, > from ../../gc

Re: [08/23] Add an alternative splay tree implementation

2021-01-01 Thread Andreas Schwab
That doesn't build with gcc 4.8: In file included from ../../gcc/splay-tree-utils.h:491:0, from ../../gcc/rtl-ssa.h:45, from ../../gcc/fwprop.c:29: ../../gcc/splay-tree-utils.tcc:24:1: error: prototype for 'typename base_splay_tree::node_type base_splay_tree::ge

Re: [08/23] Add an alternative splay tree implementation

2020-12-16 Thread Richard Sandiford via Gcc-patches
Jeff Law writes: > On 11/13/20 1:15 AM, Richard Sandiford via Gcc-patches wrote: >> We already have two splay tree implementations: the old C one in >> libiberty and a templated reimplementation of it in typed-splay-tree.h. >> However, they have some drawbacks: >> >> - They hard-code the assumptio

Re: [08/23] Add an alternative splay tree implementation

2020-12-02 Thread Jeff Law via Gcc-patches
On 11/13/20 1:15 AM, Richard Sandiford via Gcc-patches wrote: > We already have two splay tree implementations: the old C one in > libiberty and a templated reimplementation of it in typed-splay-tree.h. > However, they have some drawbacks: > > - They hard-code the assumption that nodes should ha

[08/23] Add an alternative splay tree implementation

2020-11-13 Thread Richard Sandiford via Gcc-patches
We already have two splay tree implementations: the old C one in libiberty and a templated reimplementation of it in typed-splay-tree.h. However, they have some drawbacks: - They hard-code the assumption that nodes should have both a key and a value, which isn't always true. - They use the two-