Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

2021-02-01 Thread Xing GUO via Gcc-patches
Hi, I've reproduced the failure. It's because my gcc is configured as a bare-metal toolchain and built with binutils that supports RISC-V attribute. That is to say, my gcc emits RISC-V attributes by default. Below is the patch that should fix the failure. Sorry for the inconvenience. diff --git a

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

2021-01-31 Thread Xing GUO via Gcc-patches
Hi Andreas and Kito, I haven't reproduced this failure, but it looks that I forget to append `-mriscv-attribute` to dg-options in attribute-18.c. I'll reply to this thread ASAP. Thanks, Xing On 2/1/21, Andreas Schwab wrote: > FAIL: gcc.target/riscv/attribute-18.c scan-assembler .attribute arch,

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

2021-01-26 Thread Xing GUO via Gcc-patches
Sorry, I forgot to remove the line '*explicit_version_p = true;' in my previous patch. This is an updated patch. Thanks! --- gcc/ChangeLog: * common/config/riscv/riscv-common.c (riscv_subset_list::parsing_subset_version): Fix -march option parsing when `p` extension exists. gcc

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

2021-01-21 Thread Xing GUO via Gcc-patches
egards, Xing > On Jan 22, 2021, at 2:26 PM, Kito Cheng wrote: > > Hi Xing: > > Thanks for your patch, but I would like to know did you have the > copyright assignment for FSF? or your employee/company has signed > that? > > On Thu, Jan 21, 2021 at 8:48 PM Xing GUO via

[PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

2021-01-21 Thread Xing GUO via Gcc-patches
This patch fixes -march option parsing when `p` extension exists, e.g., -march=rv64imafdcp should produce .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c2p0_p" rather than .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c_p" --- gcc/ChangeLog: * common/config/riscv/riscv-common.c (risc