Ok, the following patch works for Android:
2014-12-09 Varvara Rainchik
* config.h.in: Regenerate.
* configure: Regenerate.
* configure.ac: Add GCC_CHECK_EMUTLS.
* libgomp.h: Add check for USE_EMUTLS: this case
is equal to HAVE_TLS.
* team.c
Can we instead of adding new macroses in config/tls.m4 use something
like that in libgomp:
#if defined (HAVE_TLS) && defined (USE_EMUTLS)
(with GCC_CHECK_EMUTLS in libgomp/configure.ac)?
2014-12-08 19:28 GMT+03:00 Jakub Jelinek :
> On Mon, Dec 08, 2014 at 07:01:09PM +0300, Varva
Is it ok to add GCC_CHECK_EMUTLS test in libgomp/configure.ac or
should I add in tls.m3 a similair test that would be used only in
libgomp?
2014-12-08 17:03 GMT+03:00 Jakub Jelinek :
> On Mon, Dec 08, 2014 at 04:30:46PM +0300, Varvara Rainchik wrote:
>> Hi guys,
>>
>> Could y
Hi guys,
Could you please take a look at this issue? This fix is still urgent
for Android.
2014-12-01 18:25 GMT+03:00 Varvara Rainchik :
> Hi Jakub,
>
> Do you think this patch is ok for upstream:
>
> 2014-12-01 Varvara Rainchik
>
> * libgomp/libgomp.h: Eliminate
Hi Jakub,
Do you think this patch is ok for upstream:
2014-12-01 Varvara Rainchik
* libgomp/libgomp.h: Eliminate case when HAVE_TLS is not defined:
always use tls emulation.
* libgomp/team.c: Likewise.
--
diff --git a/libgomp/libgomp.h b/libgomp/libgomp.h
index
*Ping*
2014-10-13 14:48 GMT+04:00 Varvara Rainchik :
>> Now, I wonder on which OS and why does config/tls.m4 CHECK_GCC_TLS
>> actually fail? Can you figure that out?
>>
>
> On Android check passes with --disable-tls (standard while building
> gcc for Android as TLS
> Now, I wonder on which OS and why does config/tls.m4 CHECK_GCC_TLS
> actually fail? Can you figure that out?
>
On Android check passes with --disable-tls (standard while building
gcc for Android as TLS is not supported in bionic) and fails with
--enable-tls (i686-linux-android/libgomp/conftest.
10-01 Varvara Rainchik
* libgomp.h (HAVE_TLS): Set to 1.
--
--- a/libgomp/libgomp.h
+++ b/libgomp/libgomp.h
@@ -45,6 +45,8 @@
# pragma GCC visibility push(hidden)
#endif
+#define HAVE_TLS 1
+
/* If we were a C++ library, we'd get this from . */
enum memmodel
{
2014-09-30 18:40
Corrected patch: call pthread_setspecific (gomp_tls_key, NULL) in
gomp_thread_start if HAVE_TLS is not defined.
2014-09-19 Varvara Rainchik
* libgomp.h (gomp_thread): For non TLS case create thread data.
* team.c (non_tls_thread_data_destructor,
create_non_tls_thread_data
*Ping*
2014-09-19 15:41 GMT+04:00 Varvara Rainchik :
> I've corrected my patch accordingly to what you said. To diffirentiate
> second case in destructor I've added pthread_setspecific
> (gomp_tls_key, NULL) at the end of gomp_thread_start. So, destructor
> can sim
What do you think?
Changes are bootstrapped and regtested on x86_64-linux.
2014-09-19 Varvara Rainchik
* libgomp.h (gomp_thread): For non TLS case create thread data.
* team.c (non_tls_thread_data_destructor,
create_non_tls_thread_data): New functions.
---
diff --git a/libg
AM -0700, Richard Henderson wrote:
>> On 08/06/2014 03:05 AM, Varvara Rainchik wrote:
>> > * libgomp.h (gomp_thread): For non TLS case create thread data.
>> > * team.c (create_non_tls_thread_data): New function.
>> >
>> >
>> >
clone ()
2014-08-29 21:40 GMT+04:00 Richard Henderson :
> On 08/06/2014 03:05 AM, Varvara Rainchik wrote:
>> * libgomp.h (gomp_thread): For non TLS case create thread data.
>> * team.c (create_non_tls_thread_data): New function.
>>
>>
>> ---
>&
Hi again! I want to remind that issue is urgent for Android.
2014-08-13 12:13 GMT+04:00 Varvara Rainchik :
> *Ping*
>
> Thanks,
> Varvara
>
> 2014-08-06 14:05 GMT+04:00 Varvara Rainchik :
>> Hi,
>>
>> The issue was firstly observed on NDK gcc since TLS is n
*Ping*
Thanks,
Varvara
2014-08-06 14:05 GMT+04:00 Varvara Rainchik :
> Hi,
>
> The issue was firstly observed on NDK gcc since TLS is not supported
> in Android bionic. I also see the same failure on gcc configured for
> linux with –disable-tls, libgomp make check log:
>
fails, but
I think it’s other non TLS problem.
Changes are bootstrapped and regtested on x86_64-linux.
2014-08-06 Varvara Rainchik
* libgomp.h (gomp_thread): For non TLS case create thread data.
* team.c (create_non_tls_thread_data): New function.
---
diff --git a/libgomp
16 matches
Mail list logo