Re: [PATCH] [12/11/10] Fix invalid format warnings on Windows

On 5/11/22 18:43, Joseph Myers wrote: There are various coding style issues in the patch; at least missing space before '(' and '&&' at end of line (should be at start of line). It will also need to be updated for .c files having been renamed to .cc in the GCC source tree. Thanks, I've fixed

Re: [PATCH] [12/11/10] Fix invalid format warnings on Windows

On 1/13/22 10:40 AM, Martin Liška wrote: [...] Apart from that, I support the patch (I cannot approve it). Note we're now approaching stage4 and this is definitelly a stage1 material (opens after GCC 12.1.0 gets released). Thanks, Martin, I've updated the patch following your suggestions. Ch

Re: [PATCH] [12/11/10] Fix invalid format warnings on Windows

On 1/11/22 2:37 PM, Martin Liška wrote: Hello. I do support the patch, but I would ... Thanks, Martin,  that makes the patch simpler and easier to maintain. Would the attached version do? Thanks Tomas On 1/7/22 19:33, Tomas Kalibera wrote: +  if (is_attribute_p ("format", get_a

[PATCH] [12/11/10] Fix invalid format warnings on Windows

Mingw32 targets use ms_printf format for printf, but mingw-w64 when configured for UCRT uses gnu_format (via stdio.h).  GCC then checks both formats, which means that one cannot print a 64-bit integer without a warning. All these lines issue a warning:   printf("Hello %"PRIu64"\n", x); // 1   p

[PATCH] mh-mingw: Set __USE_MINGW_ACCESS in missed C++ flags variables (gcc-10)

This is exactly what was done already in gcc-11 and trunk by 89e95ad2e7679322b2f5ee9070ff2721d5ca1d6d but it would be great to apply also to gcc-10. It is needed for the driver (compiled by C++) to find cc1, cc1plus, etc. More details in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101238 co