Re: [PATCH 14/24] libtool.m4: fix nm BSD flag detection

2023-08-07 Thread Nick Alcock via Gcc-patches
On 7 Aug 2023, Jeff Law uttered the following: > On 8/7/23 04:32, Arsen Arsenović via Gcc-patches wrote: >> From: Nick Alcock >> Libtool needs to get BSD-format (or MS-format) output out of the system >> nm, so that it can scan generated object files for symbol names for >> -export-symbols-regex

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

2021-09-09 Thread Nick Alcock via Gcc-patches
On 21 Jul 2021, Alan Modra uttered the following: > On Wed, Jul 07, 2021 at 08:03:45PM +0100, Nick Alcock via Gcc-patches wrote: >> >>> PR libctf/27482 >> >>> * libtool.m4 (LT_PATH_NM): Try BSDization flags with a user-provided >> > >> >

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

2021-07-07 Thread Nick Alcock via Gcc-patches
On 7 Jul 2021, Nick Clifton told this: > Hi Nick, > >> Ping? > > Oops. I sent a bunch of pings out at the same time, to a bunch of different projects. You are the only person to respond, so thank you! >>> PR libctf/27482 >>> * libtool.m4 (LT_PATH_NM): Try BSDization flags with a user-pro

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

2021-07-06 Thread Nick Alcock via Gcc-patches
Ping? On 25 Jun 2021, Nick Alcock via Binutils said this: > Libtool needs to get BSD-format (or MS-format) output out of the system > nm, so that it can scan generated object files for symbol names for > -export-symbols-regex support. Some nms need specific flags to turn on > BSD-formatted outpu

[PATCH 0/4 REVIEW] libtool and libctf fixes for Solaris 11

2021-06-25 Thread Nick Alcock via Gcc-patches
There are three intertwined bugs here, two in libtool.m4, one in libctf. The underlying "problem" is that libctf tries to version its symbols: if it can't use a GNU version script it tries to hide unnecessary symbols using Libtool's --export-symbols-regex flag... and that flag has kinda rusted. Fi

[PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

2021-06-25 Thread Nick Alcock via Gcc-patches
Libtool needs to get BSD-format (or MS-format) output out of the system nm, so that it can scan generated object files for symbol names for -export-symbols-regex support. Some nms need specific flags to turn on BSD-formatted output, so libtool checks for this in its AC_PATH_NM. Unfortunately the c

[PATCH 1/4] libtool.m4: augment symcode for Solaris 11

2021-06-25 Thread Nick Alcock via Gcc-patches
This reports common symbols like GNU nm, via a type code of 'C'. Cc: gcc-patches@gcc.gnu.org ChangeLog 2021-06-22 Nick Alcock PR libctf/27967 * libtool.m4 (lt_cv_sys_global_symbol_pipe): Augment symcode for Solaris 11. --- libtool.m4 | 2 +- 1 file changed, 1 insertio

[PATCH 4/8] intl: turn LIBINTL into -L / -l form

2021-02-08 Thread Nick Alcock via Gcc-patches
This variable currently refers directly, not to a .la file, but to an .a file. This produces wrong results when building into a library on some platforms: so convert it to the general form "-L${top_builddir}../intl -lintl ..." ... so that both libtool and non-libtool builds will always do the righ

[PATCH 3/8] intl: always picify

2021-02-08 Thread Nick Alcock via Gcc-patches
libintl is included in several shared libraries (at least libinproctrace.so and libctf.so): unconditionally picify with code borrowed from libiberty configure. (It's not performance-critical, so don't bother making separate PIC and non-PIC libraries like libiberty does.) Cc: gcc-patc...@gnu.org

[PATCH 0/8 RFC] unbreak --with-included-gettext, and other configury stuff

2021-02-08 Thread Nick Alcock via Gcc-patches
Most of this series serves one goal: fixing problems Stephen Casner reported with a binutils built --with-included-gettext or built on a platform that doesn't have a gettext in a system libintl or in libc. This has long been broken in binutils. Firstly, two commits from last year that allow intl/

[PATCH v2] ld: depend on libctf

2021-01-26 Thread Nick Alcock via Gcc-patches
Since ld may depend on libctf (if present), and libctf may be relinked by the installation process, libctf must be installed before ld is, or the relink may fail if it calls on symbols or symbol versions that do not exist in any libctf already present on the system. (If none is present, the copy i

Re: [PATCH] ld: depend on libctf

2021-01-26 Thread Nick Alcock via Gcc-patches
On 26 Jan 2021, Andreas Schwab outgrape: > On Jan 26 2021, Nick Alcock via Gcc-patches wrote: > >> diff --git a/Makefile.in b/Makefile.in >> index 03785200dc7..d8a94c4173d 100644 >> --- a/Makefile.in >> +++ b/Makefile.in >> @@ -565,7 +565,7 @@ S

Re: [PATCH] config: check for sighandler_t properly

2021-01-26 Thread Nick Alcock via Gcc-patches
On 25 Jan 2021, Nathan Sidwell said: > I think you're right about checking though, not I'll look at it once I've dealt with this unfortunate "installing binutils leaves the system linker broken" disaster I've caused. :) -- NULL && (void)

[PATCH] ld: depend on libctf

2021-01-26 Thread Nick Alcock via Gcc-patches
Since ld may depend on libctf (if present), and libctf may be relinked by the installation process, libctf must be installed before ld is, or the relink may fail if it calls on symbols or symbol versions that do not exist in any libctf already present on the system. (If none is present, the copy i

Re: [PATCH] config: check for sighandler_t properly

2021-01-25 Thread Nick Alcock via Gcc-patches
On 25 Jan 2021, Nathan Sidwell uttered the following: > On 1/22/21 12:19 PM, Nick Alcock wrote: >> Searching for sighander_t is unlikely to succeed anywhere. >> >> The attempt to #include is also not working, >> and fixing it shows that doing an AC_DEFINE in the body of >> an AC_CHECK_TYPE like t

[PATCH] config: check for sighandler_t properly

2021-01-22 Thread Nick Alcock via Gcc-patches
Searching for sighander_t is unlikely to succeed anywhere. The attempt to #include is also not working, and fixing it shows that doing an AC_DEFINE in the body of an AC_CHECK_TYPE like that is also risky: both fixed. (The purpose of this check is opaque to me: neither libcody nor GCC ever includ

[PATCH v2 toplevel] sync libctf toplevel from binutils-gdb

2021-01-06 Thread Nick Alcock via Gcc-patches
This pulls in the toplevel portions of these binutils-gdb commits: 1ff6de031241c59d0ff bfd, ld: add CTF section linking 87279e3cef5b2c54f4a libctf: installable libctf as a shared library c59e30ed1727135f8ef libctf: new testsuite * Makefile.def: Sync with binutils-gdb: (de

Re: [PATCH toplevel] libctf: new testsuite

2021-01-06 Thread Nick Alcock via Gcc-patches
On 5 Jan 2021, Alan Modra via Binutils told this: > It doesn't apply due to gcc missing binutils 87279e3cef5b2c5 changes > too. I could fix that easily enough but I'm going to ask that you > post a combined patch to bring the gcc repo up to date with any libctf > changes. Oops! That never occurr

[PATCH toplevel] libctf: new testsuite

2021-01-05 Thread Nick Alcock via Gcc-patches
This enables 'make libctf-check', used by a new libctf testsuite in binutils. 2021-01-05 Nick Alcock * Makefile.def (libctf): No longer no_check. Checking depends on all-ld. * Makefile.in: Regenerated. --- Makefile.def | 4 +- Make

Re: RFA: Remove use of register keyword in libiberty.h

2020-06-25 Thread Nick Alcock via Gcc-patches
On 25 Jun 2020, Nick Clifton outgrape: > Hi Ian, Hi Nick, > > Comping the GOLD linker with Clang has started producing this error > message: > > In file included from gold/archive.cc:29: > include/libiberty.h:646:25: error: 'register' storage class > specifier is deprecated and i

[PATCH v2] libiberty, include: add bsearch_r

2020-06-23 Thread Nick Alcock via Gcc-patches
libctf wants a bsearch that takes a void * arg pointer to avoid a nonportable use of __thread. bsearch_r is required, not optional, at this point because as far as I can see this obvious-sounding function is not implemented by anyone's libc. We can easily move it to AC_LIBOBJ later if it proves n

[PATCH] libiberty, include: add bsearch_r

2020-06-23 Thread Nick Alcock via Gcc-patches
libctf wants a bsearch that takes a void * arg pointer to avoid a nonportable use of __thread. bsearch_r is required, not optional, at this point because as far as I can see this obvious-sounding function is not implemented by anyone's libc. We can easily move it to AC_LIBOBJ later if it proves n

[PATCH] libiberty, include: add bsearch_r

2020-06-16 Thread Nick Alcock via Gcc-patches
A resend of something I sent over, sheesh, six months ago. Jeff Law acked it but, well, it was six months ago. I think getting a re-ack might be a good idea. (Also... could someone push it for me? I should have push privs, but only on binutils and I have yet to test them. Starting my pushing car