This was committed to Rust's copy of libbacktrace in October by Carlos
Liam.
Thanks for your time,
Michael
diff --git a/src/libbacktrace/ChangeLog.jit b/src/libbacktrace/ChangeLog.jit
index 6b60e3b..5ab329c 100644
--- a/src/libbacktrace/ChangeLog.jit
+++ b/src/libbacktrace/ChangeLog.jit
@@ -6,7
DJ Delorie wrote:
>
> > --- libiberty/pex-win32.c
> > +++ /tmp/cocci-output-25924-3a75ca-pex-win32.c
> > @@ -547,8 +547,8 @@ env_compare (const void *a_ptr, const vo
> >
> >do
> > {
> > - c1 = (unsigned char) tolower (*a++);
> > - c2 = (unsigned char) tolower (*b++);
> > +
Hi, everyone.
While it often (usually?) isn't an issue, passing a signed char to ctype
functions is undefined. Here's the CERT entry:
https://www.securecoding.cert.org/confluence/x/fAs
This means that we need to cast chars to unsigned char before passing
them to one of these functions.