Re: [PATCH] PING implement pre-c++20 contracts

2021-05-28 Thread Jeff Chapman via Gcc-patches
e specific comments inline below. On 5/17/21, Jason Merrill wrote: > On 5/14/21 4:54 PM, Jason Merrill wrote: >> On 4/30/21 1:44 PM, Jeff Chapman wrote: >>> Hello! Looping back around to this. re: >>> https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567334.html >

Re: [PATCH] PING implement pre-c++20 contracts

2021-04-30 Thread Jeff Chapman via Gcc-patches
Hello! Looping back around to this. re: https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567334.html On 3/25/21, Jason Merrill wrote: > On 3/1/21 8:12 AM, Jeff Chapman wrote: >> On 1/18/21, Jason Merrill wrote: >>> On 1/4/21 9:58 AM, Jeff Chapman wrote: >>

Re: [PATCH] PING implement pre-c++20 contracts

2021-03-01 Thread Jeff Chapman via Gcc-patches
On 1/18/21, Jason Merrill wrote: > On 1/4/21 9:58 AM, Jeff Chapman wrote: >> Ping. re: >> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561135.html >> <https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561135.html> >> >> https://gith

[PATCH] PING implement pre-c++20 contracts

2021-01-04 Thread Jeff Chapman via Gcc-patches
much through regular merges, or would it be more beneficial for it to be left alone so you have a more stable review target? Please let me know if there's initial feedback I can start addressing, or anything I can do to help the review process along in general. Thank you, Jeff Chapman

Re: [PATCH] implement pre-c++20 contracts

2020-12-04 Thread Jeff Chapman via Gcc-patches
> OK, I'll start with -alt then, thanks. Andrew is exactly correct, contracts-jac-alt is still the current branch we're focusing our upstreaming efforts on. It's trailing upstream master by a fair bit at this point. I'll get a merge pushed shortly. Please let me know if there's anything I can do

[PATCH 2/2] modules: c++: Fix cross module member redecl/add long distance friendship warning

2020-08-14 Thread Jeff Chapman via Gcc-patches
Attached is a patch adding a -Wlong-distance-friends flag to diagnose long distance (cross module) friendship. 2020-08-14 Jeff Chapman II gcc/c-family/ * c.opt (Wlong-distance-friends): New. gcc/cp/ * cp-tree.h (module_friendship_compatible): New. * friend.c

[PATCH 1/2] modules: c++: Fix cross module member redecl/add long distance friendship warning

2020-08-14 Thread Jeff Chapman via Gcc-patches
issue where a friend decl lets a user define a function owned by a different module. 2020-08-14 Jeff Chapman II gcc/cp/ * decl.c (duplicate_decls): Return original decl when attempting to redeclare a function owned by another module instead of clobbering the original decl

[PATCH] modules: c++: Fix push_namespace ICE with modules

2020-08-14 Thread Jeff Chapman via Gcc-patches
's what it should be instead. 2020-05-15 Jeff Chapman II gcc/cp/ * name-lookup.c (push_namespace): Fix slot invalidation related ICE when compiling with modules enabled. gcc/testsuite/ * g++.dg/modules/string-view1.C: New test. * g++.dg/modules/string

Re: [PATCH] implement pre-c++20 contracts

2020-07-28 Thread Jeff Chapman via Gcc-patches
Ping. Any feedback would be appreciated :) re: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549868.html older reply: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545339.html On 7/10/20, Jeff Chapman wrote: > Hello again :) > > Attached is a new squashed revision of the p

Re: [PATCH] implement pre-c++20 contracts

2020-07-10 Thread Jeff Chapman via Gcc-patches
Hello again :) Attached is a new squashed revision of the patch sans ChangeLogs. The current work is now being done on github: https://github.com/lock3/gcc/tree/contracts-jac-alt Please let me know if there's a better way to share revisions. >>> + /* Check that assertions are null statements.

Re: [PATCH] implement pre-c++20 contracts

2020-05-07 Thread Jeff Chapman via Gcc-patches
Hello, On 12/10/19, Jason Merrill wrote: > On 11/13/19, Jeff Chapman wrote: >> Attached is a patch that implements pre-c++20 contracts. This comes >> from a long running development branch which included ChangeLog entries >> as we went, which are included in the patch

[PATCH] implement pre-c++20 contracts

2019-11-13 Thread Jeff Chapman
e. Thank you, Jeff Chapman II 0001-Implement-pre-c-20-contracts.patch.gz Description: application/gzip

[PATCH] PR c++/84810 - constraints on lambdas

2019-10-30 Thread Jeff Chapman
lambda. gcc/cp/ 2019-10-30 Jeff Chapman II PR c++/84810 - constraints on lambdas * lambda.c (maybe_add_lambda_conv_op): Do not synthesize conversion if the call operator does not satisfy its constraints. * parser.c (cp_parser_lambda_declarator_opt): Parse