Re: The COBOL front end, in 8 notes

2024-12-14 Thread Eric Gallager
On Sat, Dec 14, 2024 at 8:09 AM Iain Sandoe wrote: > > > > > On 14 Dec 2024, at 11:56, Iain Sandoe wrote: > > > > > > > >> On 14 Dec 2024, at 10:11, Sam James wrote: > >> > >> David Malcolm writes: > >> > >>> On Thu, 2024-12-12 at 12:56 -0500, James K. Lowden wrote: > The following 8 patch

Re: [PATCH] gcc: download_prerequisites: add --verbose and --no-verbose

2024-12-03 Thread Eric Gallager
On Tue, Dec 3, 2024 at 7:09 AM Tiezhu Yang wrote: > > When executing the script download_prerequisites, the download speed may > be extremely slow and there is no any output, the users do not know what > happened. > > Given the command wget and curl have options --verbose and --no-verbose, > add t

Re: [PATCH] AIX Build failure with default -std=gnu23.

2024-12-02 Thread Eric Gallager
On Mon, Dec 2, 2024 at 1:01 PM swamy sangamesh wrote: > > Dear Community, > > Please let me know your comment. > Or is it more appropriate to have changes with header guard like this ? > I personally think it's better to just remove the define, but if you're going to leave it in and guard it with

Re: [PATCH] Add -f{,no-}assume-sane-operators-new-delete{,={0,1,2}} options [PR110137]

2024-11-18 Thread Eric Gallager
On Fri, Nov 15, 2024 at 11:08 AM Jakub Jelinek wrote: > > Hi! > > The following patch adds a new tristate option for optimizations related to > replaceable global operators new/delete. > The option isn't called -fassume-sane-operator-new (which clang++ > implements), because > 1) clang++ option me

Re: [PATCH v2] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

2024-11-18 Thread Eric Gallager
On Wed, Nov 13, 2024 at 6:48 AM Alejandro Colomar wrote: > > Hi Eric, > > On Thu, Oct 17, 2024 at 03:20:11PM GMT, Eric Gallager wrote: > > On Thu, Oct 17, 2024 at 10:54 AM Alejandro Colomar wrote: > > > > > > Just like we already do for git-send-email(1

Re: [PATCH v1] autoupdate: replace obsolete macros in libiberty

2024-11-18 Thread Eric Gallager
On Mon, Nov 18, 2024 at 7:05 AM Matthieu Longo wrote: > > Autoreconf-2.72 warns about obsolete macros. This patch aims at removing > the noise from a future upgrade to autoreconf-2.72 or later. This is in > no a way a complete patch allowing the upgrade to autoreconf-2.72. > Hi, thanks for doing

Re: [PATCH] c: Introduce -Wfree-labels

2024-11-18 Thread Eric Gallager
On Fri, Nov 15, 2024 at 3:12 PM Jakub Jelinek wrote: > > On Fri, Nov 15, 2024 at 08:13:28PM +0100, Florian Weimer wrote: > > * Andrew Pinski: > > > > > On Fri, Nov 15, 2024 at 9:13 AM Florian Weimer wrote: > > >> > > >> This is another recent GCC extension whose use is apparently > > >> difficult

Re: [PATCH] gcc: Remove trailing whitespace

2024-10-24 Thread Eric Gallager
On Thu, Oct 24, 2024 at 4:17 AM Jakub Jelinek wrote: > > Hi! > > I've tried to build stage3 with > -Wleading-whitespace=blanks -Wtrailing-whitespace=blank > -Wno-error=leading-whitespace=blanks -Wno-error=trailing-whitespace=blank So wait, it's "blanks" (plural) when it's leading, but "blank" (s

Re: [PATCH v2] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

2024-10-17 Thread Eric Gallager
; configuration. By adding the TO in the email file, we make sure that > gcc-patches@ will receive the patch. > > contrib/ChangeLog: > > * gcc-git-customization.sh: Configure git-format-patch(1) to add > 'To: gcc-patches@gcc.gnu.org'. > > Cc:

Re: [PATCH v1] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

2024-10-16 Thread Eric Gallager
On Wed, Oct 16, 2024 at 8:55 AM Alejandro Colomar wrote: > > Just like we already do for git-send-email(1). In some cases, patches > are prepared with git-format-patch(1), but are sent with a different > program, or some flags to git-send-email(1) may accidentally inhibit the > configuration. By

Re: [PATCH 5/5] passes: Remove limit on the number of params

2024-10-14 Thread Eric Gallager
On Mon, Oct 14, 2024 at 10:17 AM Andrew Pinski wrote: > > On Mon, Oct 14, 2024 at 6:10 AM Richard Biener > wrote: > > > > On Mon, Oct 14, 2024 at 4:32 AM Andrew Pinski > > wrote: > > > > > > Having a limit of 2 params for NEXT_PASS was just done because I didn't > > > think there was > > > a w

Re: [PATCH RFC] build: enable C++11 narrowing warnings

2024-10-13 Thread Eric Gallager
On Tue, Sep 24, 2024 at 2:41 AM Richard Biener wrote: > > On Mon, Sep 23, 2024 at 3:41 PM Jason Merrill wrote: > > > > On 9/23/24 9:05 AM, Richard Biener wrote: > > > On Sat, Sep 21, 2024 at 2:49 AM Jason Merrill wrote: > > >> > > >> Tested x86_64-pc-linux-gnu. OK for trunk? > > >> > > >> -- 8<

Re: [PATCH v2] Add -ftime-report-wall

2024-10-10 Thread Eric Gallager
On Mon, Oct 7, 2024 at 6:27 AM Richard Biener wrote: > > On Sat, Oct 5, 2024 at 10:17 AM Andi Kleen wrote: > > > > From: Andi Kleen > > > > Time vars normally use times(2) to get the user/sys/wall time, which is > > always a > > system call. I don't think the system time is very useful because

Re: [PATCH 3/3] aarch64: libgcc: Add -Werror support

2024-10-10 Thread Eric Gallager
On Wed, Oct 9, 2024 at 4:54 AM Christophe Lyon wrote: > > On Wed, 9 Oct 2024 at 03:05, Eric Gallager wrote: > > > > On Tue, Oct 8, 2024 at 6:25 AM Richard Sandiford > > wrote: > > > > > > Christophe Lyon writes: > > > > When --enable-

Re: [PATCH 3/3] aarch64: libgcc: Add -Werror support

2024-10-08 Thread Eric Gallager
On Tue, Oct 8, 2024 at 6:25 AM Richard Sandiford wrote: > > Christophe Lyon writes: > > When --enable-werror is enabled when running the top-level configure, > > it passes --enable-werror-always to subdirs. Some of them, like > > libgcc, ignore it. > > > > This patch adds support for it, enabled

Re: [PATCH 2/2] c++: -Wdeprecated enables later standard deprecations

2024-10-03 Thread Eric Gallager
On Thu, Oct 3, 2024 at 12:41 PM Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu, applying to trunk. > > -- 8< -- > > By default -Wdeprecated warns about deprecations in the active standard. > When specified explicitly, let's also warn about deprecations in later > standards. > > gcc/c-family/C

Re: [PATCH 2/2] gcc: make Valgrind errors fatal with --enable-checking=valgrind

2024-10-03 Thread Eric Gallager
On Wed, Oct 2, 2024 at 10:43 PM Sam James wrote: > > Valgrind doesn't error out by default which means bootstrap issues like > in PR116945 can easily be missed: pass --exit-errorcode=1 to handle this. > > gcc/ChangeLog: > PR other/116945 > PR other/116947 > > * gcc.cc (exec

Re: [PATCH] libcpp, v2: Add -Wtrailing-whitespace= warning

2024-09-19 Thread Eric Gallager
On Thu, Sep 19, 2024 at 4:35 PM Jakub Jelinek wrote: > > On Thu, Sep 19, 2024 at 08:17:24AM +0200, Richard Biener wrote: > > On Wed, Sep 18, 2024 at 7:33 PM Jakub Jelinek wrote: > > > > > > On Wed, Sep 18, 2024 at 06:17:58PM +0100, Richard Sandiford wrote: > > > > +1 I'd much rather learn about

Re: [PATCH] libcpp: Add -Wtrailing-blanks warning

2024-09-18 Thread Eric Gallager
On Wed, Sep 18, 2024 at 1:33 PM Jakub Jelinek wrote: > > On Wed, Sep 18, 2024 at 06:17:58PM +0100, Richard Sandiford wrote: > > +1 I'd much rather learn about this kind of error before the code reaches > > a review tool :) > > > > >From a quick check, it doesn't look like Clang has this, so there

Re: RFC PATCH: contrib/test_summary mode for submitting testsuite results to bunsen

2024-09-17 Thread Eric Gallager
On Tue, Sep 17, 2024 at 11:13 AM Frank Ch. Eigler wrote: > > Hi - > > > [...] > > I pretty much only use `contrib/test_summary` via the > > `mail-report.log` target in the top-level Makefile; maybe add a > > `bunsen` target to the top-level Makefile, too, to simplify invoking > > it? > > Something

Re: [PATCH] Makefile: Fix typos

2024-09-15 Thread Eric Gallager
On Wed, Sep 11, 2024 at 11:24 AM Andrew Kreimer wrote: > > On Wed, Sep 11, 2024 at 11:06:40AM -0400, Eric Gallager wrote: > > On Wed, Sep 11, 2024 at 7:32 AM Andrew Kreimer wrote: > > > > > > Fix typos in comments. > > > > > > Signed-off-by: A

Re: RFC PATCH: contrib/test_summary mode for submitting testsuite results to bunsen

2024-09-14 Thread Eric Gallager
On Fri, Sep 13, 2024 at 4:19 PM Frank Ch. Eigler wrote: > > Hi - > > The gcc-testresults mailing list is a well-established place to plop > snippets of testsuite results. It's an okay way to archive and > distribute overall counts, but it's not machine readable, and it's way > incomplete (lacks .

Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-09-12 Thread Eric Gallager
On Wed, Sep 11, 2024 at 5:28 PM Jakub Jelinek wrote: > > Hi! > > The following patch implements the clang -Wheader-guard warning, which warns > if a valid multiple inclusion header guard's #ifndef/#if !defined directive > is immediately (no other non-line directives nor other (non-comment) > token

Re: [PATCH v1][GCC] aarch64: Add GCS build attributes support.

2024-09-12 Thread Eric Gallager
On Wed, Sep 11, 2024 at 11:51 AM Srinath Parvathaneni wrote: > > This patch adds support for aarch64 gcs build attributes. Hi, just wondering if you could clarify what "GCS" stands for in this context? When I see it, my first thought is "GNU Coding Standards", but I don't think that's right... >

Re: [PATCH] Makefile: Fix typos

2024-09-11 Thread Eric Gallager
On Wed, Sep 11, 2024 at 7:32 AM Andrew Kreimer wrote: > > Fix typos in comments. > > Signed-off-by: Andrew Kreimer > --- > Makefile.def | 2 +- > Makefile.in | 4 ++-- > Makefile.tpl | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Makefile.def b/Makefile.def > inde

Re: [PATCH RFC] c-family: add attribute flag_enum [PR46457]

2024-09-04 Thread Eric Gallager
On Wed, Sep 4, 2024 at 8:18 AM Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu. Any objections? > > -- 8< -- > > Several PRs complain about -Wswitch warning about a case for a bitwise > combination of enumerators. Clang has an attribute flag_enum to prevent > this; let's adopt that approach

Re: [PATCH] libstdc++: Remove note from the GCC 4.0.1 days

2024-08-18 Thread Eric Gallager
On Sun, Aug 18, 2024 at 4:52 AM Gerald Pfeifer wrote: > > When I updated one of the links yesterday I noticed we have this obsolete > reference to GCC 4.0.1 and binutils 2.15.90.0.1.1 from 19 (nineteen) years > ago. > > I suggest we remove these. > Instead of just removing it, I wonder if it migh

Re: [PATCH] ltmain.sh: allow more flags at link-time

2024-08-14 Thread Eric Gallager
On Wed, Aug 14, 2024 at 8:50 AM Sam James wrote: > > libtool defaults to filtering flags passed at link-time. > > This brings the filtering in GCC's 'fork' of libtool into sync with > upstream libtool commit 22a7e547e9857fc94fe5bc7c921d9a4b49c09f8e. I think it'd be worthwhile to link to the upstr

Re: [PATCH] doc: Document -O1 as the preferred level for large machine-generated code

2024-07-25 Thread Eric Gallager
On Tue, Jul 23, 2024 at 10:07 AM Sam James wrote: > > At -O1, the intention is that we compile things in a "reasonable" amount > of time (ditto memory use). In particular, we try to especially avoid > optimizations which scale poorly on pathological cases, as is the case > for large machine-genera

Re: [PATCH] c++: missing -Wunused-value for ! [PR114104]

2024-07-16 Thread Eric Gallager
On Tue, Jul 16, 2024 at 10:50 AM Jason Merrill wrote: > > On 7/16/24 10:31 AM, Eric Gallager wrote: > > On Mon, Jul 15, 2024 at 10:37 PM Patrick Palka wrote: > >> > >> Bootstrapped andrregtested on x86_64-pc-linux-gnu, does this look > >> OK for trunk?

Re: [PATCH] c++: missing -Wunused-value for ! [PR114104]

2024-07-16 Thread Eric Gallager
On Mon, Jul 15, 2024 at 10:37 PM Patrick Palka wrote: > > Bootstrapped andrregtested on x86_64-pc-linux-gnu, does this look > OK for trunk? > > -- >8 -- > > Here we're neglecting to emit a -Wunused-value for eligible ! operator > expressions, and in turn for != operator expressions that are rewrit

Re: libbacktrace patch committed: Add clang optnone attribute

2024-07-11 Thread Eric Gallager
On Thu, Jul 11, 2024 at 7:19 PM Andrew Pinski wrote: > > On Thu, Jul 11, 2024 at 4:14 PM Ian Lance Taylor wrote: > > > > The libbacktrace testsuite was not passing when run with current > > versions of clang. Add the optnone attribute to make it pass. Add > > -Wno-attributes and -Wno-unknown-at

Re: [PATCH] libstdc++: Add script to update docs for a new release branch

2024-06-26 Thread Eric Gallager
On Wed, Jun 26, 2024 at 4:28 PM Jonathan Wakely wrote: > > Pushed to trunk. We have nearly a year to make improvements to it > before it's needed for the gcc-15 branch ... I just hope I remember it > exists when we branch ;-) Maybe you could leave a note about it in the docs somewhere? > > On We

Re: PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-06-26 Thread Eric Gallager
On Wed, May 29, 2024 at 5:06 PM David Malcolm wrote: > > On Wed, 2024-05-29 at 16:35 -0400, Eric Gallager wrote: > > On Tue, May 28, 2024 at 1:21 PM David Malcolm > > wrote: > > > > > > Ping. > > > > > > This patch has actually been *very

Re: [PATCH] c-family: Introduce the -Winvalid-noreturn flag from clang with extra tuneability

2024-06-01 Thread Eric Gallager
On Sat, Jun 1, 2024 at 11:32 AM Julian Waters wrote: > > Hi Jason, > > Thanks for the reply! I'll address your comments soon. I have a > question, if there is an option defined in c.opt as an Enum, like > fstrong-eval-order, and the -no variant of the option is passed, would > the Var somehow refl

Re: [pushed] wwwdocs: news: Google+ is no more

2024-05-29 Thread Eric Gallager
Maybe also add a mention of the toolchain's Mastodon account while you're there? https://fosstodon.org/@gnutools On Sun, May 26, 2024 at 6:05 PM Gerald Pfeifer wrote: > > Keep the reference as text; just not the link. > > Gerald > --- > htdocs/news.html | 3 +-- > 1 file changed, 1 insertion(+),

Re: PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-29 Thread Eric Gallager
On Tue, May 28, 2024 at 1:21 PM David Malcolm wrote: > > Ping. > > This patch has actually been *very* helpful to me when debugging > selftest failures involving ASSERT_STREQ. > > Thanks > Dave > Currently `diff` is only listed under the "Tools/packages necessary for modifying GCC" section of ins

Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]

2024-04-17 Thread Eric Gallager
; + > + > + So, this is kind of a minor style nitpick, but personally, it kind of bothers me when autotools goes and inserts a bunch of unnecessary blank newlines in the generated output scripts. Does anyone else think it'd be worth it to scatter around some of m4's "dnl" com

Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature, extension}

2024-04-15 Thread Eric Gallager
On Mon, Apr 15, 2024 at 6:14 AM Alex Coplan wrote: > > On 04/04/2024 11:00, Alex Coplan wrote: > > Hi, > > > > This adds a note to the GCC 14 release notes mentioning support for > > __has_{feature,extension} (PR60512). > > > > OK to commit? > > Ping. Is this changes.html patch OK? I guess it ne

Re: [PATCH] gotools: Workaround non-reproduceability of automake

2024-04-15 Thread Eric Gallager
On Mon, Apr 15, 2024 at 8:43 AM Jakub Jelinek wrote: > > Hi! > > The regen bot recently flagged a difference in gotools/Makefile.in. > Trying it locally, it seems pretty random > for i in `seq 20`; do PATH=~/automake-1.15.1/bin:~/autoconf-2.69/bin:$PATH > automake; echo -n `git diff Makefile.in |

Re: [wwwdocs] gcc-14: Mention that some warnings are now errors

2024-04-13 Thread Eric Gallager
On Sat, Apr 13, 2024 at 5:51 AM Sebastian Huber wrote: > > --- > htdocs/gcc-14/changes.html | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html > index 8ac08e9a..a183fad8 100644 > --- a/htdocs/gcc-14/changes.html > +++ b/ht

Re: [PATCH] jit: Ensure ssize_t is defined.

2024-01-28 Thread Eric Gallager
On Sun, Jan 28, 2024 at 6:45 AM Iain Sandoe wrote: > > Tested on i686, x86_64 Darwin, x86_64 Linux, > OK for trunk? > > --- 8< --- > > On some targets it seems that ssize_t is not defined by any of the > headers transitively included by . This leads to a bootstrap > fail when jit is enabled. > >

Re: [PATCH] Pass GUILE down to subdirectories

2024-01-21 Thread Eric Gallager
On Thu, Jan 18, 2024 at 3:37 PM Tom Tromey wrote: > > Andrew> This change is causing some problems for me. > > Yeah, Tom de Vries as well. > > Andrew> One of my build machines has 2 versions of guile installed. One is > Andrew> guile 2.0.14 and the other is guile 2.2.21. > > Andrew> When GDB conf

Re: [PATCH] Pass GUILE down to subdirectories

2024-01-14 Thread Eric Gallager
On Sat, Jan 13, 2024 at 6:36 AM Andrew Burgess wrote: > > Tom Tromey writes: > > > When I enable cgen rebuilding in the binutils-gdb tree, the default is > > to run cgen using 'guile'. However, on my host, guile is guile 2.2, > > which doesn't work for me -- I have to use guile3.0. > > > > This

Re: [PATCH] remove qmtest-related Makefile targets

2023-12-06 Thread Eric Gallager
On Wed, Dec 6, 2023 at 12:56 PM Jeff Law wrote: > On 12/5/23 09:41, Eric Gallager wrote: > > On GitHub, Joseph Myers (@jsm28 there) says in MentorEmbedded/qmtest#1 > > that the qmtest-related targets should have been removed long ago. This > > patch does so. > > >

Re: [C PATCH, v2] Add Walloc-size to warn about insufficient size in allocations [PR71219]

2023-12-06 Thread Eric Gallager
On Wed, Dec 6, 2023 at 10:13 AM Martin Uecker wrote: > > Am Mittwoch, dem 06.12.2023 um 16:01 +0100 schrieb Jakub Jelinek: > > On Wed, Dec 06, 2023 at 03:56:10PM +0100, Martin Uecker wrote: > > > > That would be my preference because then the allocation size is > > > > correct and it is purely a s

Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads

2023-12-06 Thread Eric Gallager
On Mon, Dec 4, 2023 at 1:44 PM Tom Tromey wrote: > > > "Arsen" == Arsen Arsenović writes: > > Arsen> Thanks. I'll wait for the Binutils and GDB maintainers to weigh in > Arsen> before pushing (plus, I can't push there). > > Seems fine to me. Thank you. > > Tom LGTM; please post once it has

[PATCH] remove qmtest-related Makefile targets

2023-12-05 Thread Eric Gallager
On GitHub, Joseph Myers (@jsm28 there) says in MentorEmbedded/qmtest#1 that the qmtest-related targets should have been removed long ago. This patch does so. Ref: https://github.com/MentorEmbedded/qmtest/issues/1 gcc/ChangeLog: * Makefile.in: Remove qmtest-related targets. --- gcc/Makef

Re: [PATCH v2] doc: Update the status of build directory not fully separated

2023-12-01 Thread Eric Gallager
Please cross-reference against issue 37210 if/when merging, if it hasn't already been: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37210 On Fri, Dec 1, 2023 at 2:15 AM Richard Biener wrote: > > On Thu, Nov 30, 2023 at 2:42 PM Xi Ruoyao wrote: > > > > Recently there are some people building GCC

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-21 Thread Eric Gallager
>> libasprintf; therefore there is no need to build it. > > > > Ah, sure, that works for me too (note that the fix is to pass > > -frandom-seed=, according to Jakub, should this show up again). > > Indeed, that got a bootstrap to pass. I've also taken the opport

Re: [PATCH v3 11/11] c: Add new -Wdeclaration-missing-parameter-type permerror

2023-11-20 Thread Eric Gallager
On Mon, Nov 20, 2023 at 4:58 AM Florian Weimer wrote: > > This used to be a warning, enabled by default, without its own option. Right, I meant to ask: why create a new option of -Wdeclaration-missing-parameter-type instead of reusing the existing -Wmissing-parameter-type for this? > > A subsequ

Re: [PATCH] C99 testsuite readiness: -fpermissive tests

2023-11-11 Thread Eric Gallager
On Fri, Nov 10, 2023 at 5:06 PM Florian Weimer wrote: > > These tests use obsolete language constructs, but they are not > clearly targeting C89, either. So use -fpermissive to keep > future errors as warnings. > > The reasons why obsolete constructs are used used vary from > test to test. Some

Re: [PING] Re: [PATCH] Add files to discourage submissions of PRs to the GitHub mirror.

2023-11-01 Thread Eric Gallager
On Wed, Nov 1, 2023 at 7:25 PM Eric Gallager wrote: > > On Wed, Nov 1, 2023 at 11:31 AM Jeff Law wrote: > > > > > > > > On 11/1/23 08:11, Eric Gallager wrote: > > > Hi, I'd like to ping the following patch: > > > > > > https://gcc.gnu

Re: [PING] Re: [PATCH] Add files to discourage submissions of PRs to the GitHub mirror.

2023-11-01 Thread Eric Gallager
On Wed, Nov 1, 2023 at 11:31 AM Jeff Law wrote: > > > > On 11/1/23 08:11, Eric Gallager wrote: > > Hi, I'd like to ping the following patch: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633191.html > OK for the trunk. > Thanks, com

[PING] Re: [PATCH] Add files to discourage submissions of PRs to the GitHub mirror.

2023-11-01 Thread Eric Gallager
Hi, I'd like to ping the following patch: https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633191.html On Mon, Oct 16, 2023 at 8:50 PM Eric Gallager wrote: > > On Mon, Oct 16, 2023 at 7:58 PM Andrew Pinski wrote: > > > > On Mon, Oct 16, 2023, 16:

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

2023-10-22 Thread Eric Gallager
On Sun, Oct 22, 2023 at 4:03 PM wrote: > > On 22 October 2023 21:45:12 CEST, Jeff Law wrote: > > > > > >On 10/22/23 10:09, Andrew Pinski wrote: > >> On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: > >>> > >>> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. > >>> Definin

Re: [MAINTAINERS/KERNEL SUMMIT] Trust and maintenance of file systems

2023-10-22 Thread Eric Gallager
On Tue, Sep 12, 2023 at 5:53 AM Richard Biener via Gcc-patches wrote: > > On Thu, Sep 7, 2023 at 2:32 PM Segher Boessenkool > wrote: > > > > On Thu, Sep 07, 2023 at 02:23:00PM +0300, Dan Carpenter wrote: > > > On Thu, Sep 07, 2023 at 06:04:09AM -0500, Segher Boessenkool wrote: > > > > On Thu, Sep

Re: [PATCH] c: Add -Wreturn-mismatch warning, split from -Wreturn-type

2023-10-19 Thread Eric Gallager
On Thu, Oct 19, 2023 at 5:08 PM Florian Weimer wrote: > > The existing -Wreturn-type option covers both constraint violations > (which are mandatory to diagnose) and warnings that have known > false positives. The new -Wreturn-mismatch warning is only about > the constraint violations (missing or

Re: Enable top-level recursive 'autoreconf'

2023-10-19 Thread Eric Gallager
On Thu, Oct 19, 2023 at 6:43 AM Thomas Schwinge wrote: > > Hi! > > On 2023-10-19T11:57:33+0200, Andreas Schwab wrote: > > On Okt 19 2023, Thomas Schwinge wrote: > >> On 2023-10-18T15:42:18+0100, R jd <3246251196r...@gmail.com> wrote: > >>> I guess I can ask, why there is not a recursive approach

Re: [PATCH] Support g++ 4.8 as a host compiler.

2023-10-18 Thread Eric Gallager
On Sun, Oct 15, 2023 at 7:43 AM Richard Sandiford wrote: > > "Roger Sayle" writes: > > I'd like to ping my patch for restoring bootstrap using g++ 4.8.5 > > (the system compiler on RHEL 7 and later systems). > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/632008.html > > > > Note the p

Re: [PATCH] Add files to discourage submissions of PRs to the GitHub mirror.

2023-10-16 Thread Eric Gallager
On Mon, Oct 16, 2023 at 7:58 PM Andrew Pinski wrote: > > > > On Mon, Oct 16, 2023, 16:39 Eric Gallager wrote: >> >> Currently there is an unofficial mirror of GCC on GitHub that people >> sometimes submit pull requests to: >> https://github.com/gcc-mirror/gc

[PATCH] Add files to discourage submissions of PRs to the GitHub mirror.

2023-10-16 Thread Eric Gallager
Currently there is an unofficial mirror of GCC on GitHub that people sometimes submit pull requests to: https://github.com/gcc-mirror/gcc However, this is not the proper way to contribute to GCC, so that means that someone (usually Jonathan Wakely) has to go through the PRs and manually tell people

Re: [committed] libstdc++: Format Python code according to PEP8

2023-09-12 Thread Eric Gallager via Gcc-patches
On Tue, Sep 12, 2023 at 7:46 AM Jonathan Wakely via Gcc-patches wrote: > > Tested x86_64-linux. Pushed to trunk. > > -- >8 -- > > These files were filtered through autopep8 to reformat them more > conventionally. > Thanks for this; I'm wondering if it might be worthwhile to do likewise for other

Re: [PATH] [CLEANUP] Remove trailing whitespace characters

2023-09-11 Thread Eric Gallager via Gcc-patches
On Mon, Sep 11, 2023 at 9:43 AM Jakub Jelinek via Gcc-patches wrote: > > On Mon, Sep 11, 2023 at 09:27:48AM -0400, David Malcolm via Gcc-patches wrote: > > On Sun, 2023-09-10 at 16:36 +0200, Guillaume Gomez wrote: > > > When going through the code, I saw a lot of trailing whitespace > > > characte

Re: [PATCH] libstdc++: Reduce output of 'make check'

2023-09-08 Thread Eric Gallager via Gcc-patches
On Fri, Sep 8, 2023 at 6:32 AM Jonathan Wakely wrote: > > On Fri, 8 Sept 2023 at 03:16, Eric Gallager wrote: > > > > Maybe use $(AM_V_at) instead? That would allow it to be controlled by > > the --enable-silent-rules flag to configure, as well as make V=1 vs. > &g

Re: [PATCH] libstdc++: Reduce output of 'make check'

2023-09-07 Thread Eric Gallager via Gcc-patches
Maybe use $(AM_V_at) instead? That would allow it to be controlled by the --enable-silent-rules flag to configure, as well as make V=1 vs. make V=0 too. On Thu, Sep 7, 2023 at 9:32 AM Jonathan Wakely via Gcc-patches wrote: > > Any objections to this change? > > -- >8 -- > > This removes the 39 li

Re: RFC: Top level configure: Require a minimum version 6.8 texinfo

2023-08-29 Thread Eric Gallager via Gcc-patches
On Tue, Aug 29, 2023 at 11:23 AM Nick Clifton via Gcc-patches wrote: > > Hi Guys, > > Currently the top level configure.ac file sets the minimum required > version of texinfo to be 4.7. I would like to propose changing this > to 6.8. > > The reason for the change is that the bfd documenta

Re: [PATCH] improve error for when /usr/include isn't found [PR90835]

2023-08-19 Thread Eric Gallager via Gcc-patches
On Thu, Aug 17, 2023 at 11:38 PM Eric Gallager wrote: > > On Thu, Aug 17, 2023 at 4:05 PM Iain Sandoe wrote: > > > > Hi Eric, > > > > thanks for working on this. > > > > > On 17 Aug 2023, at 20:35, Eric Gallager wrote: > > > > > >

Re: [PATCH] improve error when /usr/include isn't found [PR90835]

2023-08-19 Thread Eric Gallager via Gcc-patches
adn't gone through properly...) On Sat, Aug 19, 2023 at 4:11 PM Jeff Law wrote: > > > > On 8/17/23 12:59, Eric Gallager via Gcc-patches wrote: > > Subject: > > [PATCH] improve error when /usr/include isn't found [PR90835] > > From: > > Eric Gal

[PATCH] improve error when /usr/include isn't found [PR90835]

2023-08-18 Thread Eric Gallager via Gcc-patches
This is a pretty simple patch that ought to help Darwin users understand better why their build is failing when they forget to pass the --with-sysroot= flag to configure. gcc/ChangeLog: PR target/90835 * Makefile.in: improve error message when /usr/include is missing ---

[PATCH] improve error when /usr/include isn't found [PR90835]

2023-08-18 Thread Eric Gallager via Gcc-patches
This is a pretty simple patch that ought to help Darwin users understand better why their build is failing when they forget to pass the --with-sysroot= flag to configure. gcc/ChangeLog: PR target/90835 * Makefile.in: improve error message when /usr/include is missing ---

Re: [PATCH] improve error for when /usr/include isn't found [PR90835]

2023-08-17 Thread Eric Gallager
On Thu, Aug 17, 2023 at 4:05 PM Iain Sandoe wrote: > > Hi Eric, > > thanks for working on this. > > > On 17 Aug 2023, at 20:35, Eric Gallager wrote: > > > > This is a pretty simple patch that ought to help Darwin users understand > > better why their build

[PATCH] improve error for when /usr/include isn't found [PR90835]

2023-08-17 Thread Eric Gallager via Gcc-patches
This is a pretty simple patch that ought to help Darwin users understand better why their build is failing when they forget to pass the --with-sysroot= flag to configure. gcc/ChangeLog: PR target/90835 * Makefile.in: improve error message when /usr/include is missing 0001-improve-er

[PING] Re: [PATCH v2] Re: [WIP] Have -Wpointer-sign be enabled by -Wextra, too [PR109836]

2023-08-16 Thread Eric Gallager via Gcc-patches
PING On Tue, Aug 8, 2023 at 8:17 PM Eric Gallager wrote: > > On Tue, May 30, 2023 at 5:42 PM Eric Gallager wrote: > > > > PR109836 is a request to have -Wpointer-sign enabled by default. There > > were points of disagreement raised in the bug report, so I figured > &

[PATCH v2] Re: [WIP] Have -Wpointer-sign be enabled by -Wextra, too [PR109836]

2023-08-08 Thread Eric Gallager via Gcc-patches
On Tue, May 30, 2023 at 5:42 PM Eric Gallager wrote: > > PR109836 is a request to have -Wpointer-sign enabled by default. There > were points of disagreement raised in the bug report, so I figured > that maybe as a compromise, the warning could just be enabled by > -Wextra, as

Re: [PATCH 06/24] toplevel: Recover tilegx/tilepro targets

2023-08-07 Thread Eric Gallager via Gcc-patches
On Mon, Aug 7, 2023 at 1:43 PM Jeff Law via Gcc-patches wrote: > On 8/7/23 04:32, Arsen Arsenović via Gcc-patches wrote: > > These are still supported in Binutils. > > > > ChangeLog: > > > > * configure: Regenerate. > > * configure.ac: Recover tilegx/tilepro targets. > OK. Good remind

Re: [PATCH 03/24] gcc-4.5 build fixes

2023-08-07 Thread Eric Gallager via Gcc-patches
On Mon, Aug 7, 2023 at 7:22 AM Arsen Arsenović via Gcc-patches wrote: > > From: Alan Modra > > Trying to build binutils with an older gcc currently fails. Working > around these gcc bugs is not onerous so let's fix them. > > include/ChangeLog: > > * xtensa-dynconfig.h (xtensa_isa_interna

Re: [PATCH 00/24] Sync shared build infrastructure with binutils-gdb

2023-08-07 Thread Eric Gallager via Gcc-patches
On Mon, Aug 7, 2023 at 7:19 AM Arsen Arsenović via Gcc-patches wrote: > > Hello, > > This patch set, combined with a sibling patch set sent on the binutils > and GDB MLs, bring up the shared infrastructure between the two projects > in sync again. > > It largely consists of cherry-picks from vario

Re: [PATCH] c++: provide #include hint for missing includes [PR110164]

2023-06-14 Thread Eric Gallager via Gcc-patches
On Wed, Jun 14, 2023 at 8:29 PM David Malcolm via Gcc-patches wrote: > > PR c++/110164 notes that in cases where we have a forward decl > of a std library type such as: > > std::array x; > > we omit this diagnostic: > > error: aggregate ‘std::array x’ has incomplete type and cannot be > defined >

Re: [RFC] Add stdckdint.h header for C23

2023-06-12 Thread Eric Gallager via Gcc-patches
On Sat, Jun 10, 2023 at 6:38 AM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > The following patch is an attempt to implement the C23 stdckdint.h > header on top of our GNU extension - __builtin_{add,sub,mul}_overflow > builtins. > > I have looked at gnulib stdckdint.h and they are full of worka

[WIP] Have -Wpointer-sign be enabled by -Wextra, too [PR109836]

2023-05-30 Thread Eric Gallager via Gcc-patches
PR109836 is a request to have -Wpointer-sign enabled by default. There were points of disagreement raised in the bug report, so I figured that maybe as a compromise, the warning could just be enabled by -Wextra, as well (I have in fact seen some projects that enable -Wextra but not -Wall). This pat

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-22 Thread Eric Gallager via Gcc-patches
On 3/4/23, Janne Blomqvist via Gcc-patches wrote: > On Wed, Mar 1, 2023 at 11:31 PM Bernhard Reutner-Fischer via Fortran > wrote: >> >> Hi! >> >> Mere cosmetics. >> >> - if (foo != NULL) >> free (foo); >> >> With the caveat that coccinelle ruins replacement whitespace or i'm >> uneducated eno

[PATCH] Silence some -Wnarrowing errors

2022-12-01 Thread Eric Gallager via Gcc-patches
I tried turning -Wnarrowing back on earlier this year, but unfortunately it didn't work due to triggering a bunch of new errors. This patch silences at least some of them, but there will still be more left even after applying it. (When compiling with clang, technically the warning flag is -Wc++11-n

Re: [PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag

2022-12-01 Thread Eric Gallager via Gcc-patches
On Fri, Dec 2, 2022 at 12:30 AM Sandra Loosemore wrote: > > On 12/1/22 20:29, Eric Gallager via Gcc-patches wrote: > > A pretty simple patch; borrowed from Andrew Pinski on bugzilla: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447 > > Tested by doing `./conf

[PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag

2022-12-01 Thread Eric Gallager via Gcc-patches
A pretty simple patch; borrowed from Andrew Pinski on bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447 Tested by doing `./configure --help` in the gcc subdirectory and noting that the "(or later)" made it into the output. OK for trunk? gcc/ChangeLog: PR bootstrap/59447 * confi

Re: [PATCH] docs: document sanitizers can trigger warnings

2022-10-28 Thread Eric Gallager via Gcc-patches
On Wed, Oct 26, 2022 at 7:09 AM Martin Liška wrote: > > PR sanitizer/107298 > > gcc/ChangeLog: > > * doc/invoke.texi: Document sanitizers can trigger warnings. > --- > gcc/doc/invoke.texi | 4 > 1 file changed, 4 insertions(+) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/in

Re: [PATCH v2 2/3] doc: -falign-functions is ignored under -Os

2022-10-11 Thread Eric Gallager via Gcc-patches
On Tue, Oct 11, 2022 at 5:03 PM Palmer Dabbelt wrote: > > This is implicitly mentioned in the docs, but there were some questions > in a recent patch. This makes it more exlicit that -falign-functions is > meant to be ignored under -Os. > > gcc/doc/ChangeLog > > * invoke.texi (-falign-fun

Re: [PATCH] Add --without-makeinfo

2022-10-09 Thread Eric Gallager via Gcc-patches
On Tue, Oct 4, 2022 at 11:22 AM Tom de Vries via Gcc-patches wrote: > > Hi, > > Currently, we cannot build gdb without makeinfo installed. > > It would be convenient to work around this by using the configure flag > MAKEINFO=/usr/bin/true or some such, but that doesn't work because top-level > con

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-03 Thread Eric Gallager via Gcc-patches
On Tue, Aug 2, 2022 at 11:33 PM Alexandre Oliva wrote: > > On Aug 2, 2022, Eric Gallager wrote: > > > On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva wrote: > > >> -elif test -x as$build_exeext; then > >> +elif test -x as$build_exeext \ > >

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-02 Thread Eric Gallager via Gcc-patches
On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva wrote: > > Hello, Eric, > > Thanks for looking into this. > > On Aug 1, 2022, Eric Gallager via Gcc-patches > wrote: > > >> This just reassigns the value that was retrieved a couple of lines > >> above fro

Re: [PATCH] configure: respect --with-build-time-tools [PR43301]

2022-08-01 Thread Eric Gallager via Gcc-patches
On Mon, Aug 1, 2022 at 3:54 AM Andreas Schwab wrote: > > On Jul 31 2022, Eric Gallager via Gcc-patches wrote: > > > It just makes the configure script respect the --with-build-time-tools > > flag. > > Why does it make any difference? > See the original bug report

[PATCH] configure: respect --with-build-time-tools [PR43301]

2022-07-31 Thread Eric Gallager via Gcc-patches
Hi, there's been a patch sitting in bug 43301 for over a decade that I think still makes sense to apply, so I rebased it against current trunk and found that it still applies. It just makes the configure script respect the --with-build-time-tools flag. OK to commit? ChangeLog: PR bootstrap/43

Re: [PATCH v2 1/7] config: use $EGREP instead of egrep

2022-07-07 Thread Eric Gallager via Gcc-patches
On Mon, Jun 27, 2022 at 2:07 AM Xi Ruoyao via Gcc-patches wrote: > > egrep has been deprecated in favor of grep -E for a long time, and the > next GNU grep release (3.8 or 4.0) will print a warning if egrep is used. > Unfortunately, old hosts with non-GNU grep may lack the support for -E > option.

Re: [PATCH v2 2/7] fixincludes: use grep instead of egrep/fgrep

2022-06-27 Thread Eric Gallager via Gcc-patches
On Mon, Jun 27, 2022 at 2:10 AM Xi Ruoyao via Gcc-patches wrote: > > egrep/fgrep has been deprecated in favor of grep -E/-F for a long time, > and the next grep release (3.8 or 4.0) will print a warning if egrep or > fgrep is used. Stop using egrep and fgrep so we won't see the warning. > > But,

Re: [PATCH] gcc/configure.ac: fix --enable-fixed-point enablement [PR34422]

2022-06-21 Thread Eric Gallager via Gcc-patches
Hi, I'd like to ping this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596654.html (cc-ing the build machinery maintainers listed in MAINTAINERS this time) On Tue, Jun 14, 2022 at 3:51 PM Eric Gallager wrote: > > So, in investigating PR target/34422, I discovered t

Re: [PATCH] c: Extend the -Wpadded message with actual padding size

2022-06-17 Thread Eric Gallager via Gcc-patches
On Thu, Jun 16, 2022 at 3:37 PM Vit Kabele wrote: > > When the compiler warns about padding struct to alignment boundary, it > now also informs the user about the size of the alignment that needs to > be added to get rid of the warning. Hi, thanks for taking the time to improve -Wpadded; I have b

[PATCH] gcc/configure.ac: fix --enable-fixed-point enablement [PR34422]

2022-06-14 Thread Eric Gallager via Gcc-patches
So, in investigating PR target/34422, I discovered that the gcc subdirectory's configure script had an instance of AC_ARG_ENABLE with 3rd and 4th its arguments reversed: the one where it warns that the --enable-fixed-point flag is being ignored is the one where that flag hasn't even been passed in

Re: [PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425]

2022-06-13 Thread Eric Gallager via Gcc-patches
On Mon, Jun 13, 2022 at 7:02 AM Richard Biener wrote: > > On Thu, Jun 2, 2022 at 5:54 PM Eric Gallager via Gcc-patches > wrote: > > > > So, I'm working on fixing PR bootstrap/44425, and have this patch to > > have the top-level configure script check in the valu

Re: [PING][PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425]

2022-06-11 Thread Eric Gallager via Gcc-patches
On Fri, Jun 10, 2022 at 7:22 AM Xi Ruoyao wrote: > > On Thu, 2022-06-09 at 16:04 -0400, Eric Gallager via Gcc-patches wrote: > > Hi, I'd like to ping this patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596126.html > > (cc-ing the build machinery main

[PING][PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425]

2022-06-09 Thread Eric Gallager via Gcc-patches
Hi, I'd like to ping this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596126.html (cc-ing the build machinery maintainers listed in MAINTAINERS this time) On Thu, Jun 2, 2022 at 11:53 AM Eric Gallager wrote: > > So, I'm working on fixing PR bootstrap/44425, and ha

  1   2   3   4   >