Re: [PATCH 1/2] RISC-V:Add intrinsic support for the CMOs extensions

2024-10-29 Thread Craig Topper
Jeff, should this question in the spec be resolved before merging this? https://github.com/riscv-non-isa/riscv-c-api-doc/pull/93/files#r1817437534 On Tue, Oct 29, 2024 at 8:55 AM Jeff Law wrote: > > > On 10/29/24 9:50 AM, Craig Topper wrote: > > The '# define rnum 1'

Re: [PATCH 1/2] RISC-V:Add intrinsic support for the CMOs extensions

2024-10-29 Thread Craig Topper
The '# define rnum 1' may break user code that contains a variable called rnum. On Tue, Oct 29, 2024 at 8:46 AM Jeff Law wrote: > > > On 10/29/24 4:12 AM, shiyul...@iscas.ac.cn wrote: > > From: yulong > > > > gcc/ChangeLog: > > > > * config.gcc: Add riscv_cmo.h. > > * config/r

Re: [PATCH] Add C intrinsics for scalar crypto extension

2023-11-29 Thread Craig Topper
The intrinsics that use macros are the ones that require an integer constant expression for one of the arguments. Clang needs to be able to see the constant expression as an argument to the underlying builtin. Thus the macro. Based on my previous x86 experience, gcc may only require a macro for

Re: [llvm-dev] [PATCH 0/2] Initial support for AVX512FP16

2021-07-14 Thread Craig Topper via Gcc-patches
On Wed, Jul 14, 2021 at 12:45 AM Hongtao Liu via llvm-dev < llvm-...@lists.llvm.org> wrote: > > > > > Set excess_precision_type to FLT_EVAL_METHOD_PROMOTE_TO_FLOAT16 to > > round after each operation could keep semantics right. > > And I'll document the behavior difference between soft-fp and > >

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-01 Thread Craig Topper via Gcc-patches
On Thu, Jul 1, 2021 at 4:02 PM H.J. Lu via llvm-dev wrote: > On Thu, Jul 1, 2021 at 3:40 PM Joseph Myers > wrote: > > > > On Thu, 1 Jul 2021, H.J. Lu wrote: > > > > > BTW, _Float16 software emulation may require more than just SSE > > > since we need to do _Float16 load and store with XMM regist