Re: [PATCH v2] LoongArch: Libvtv add loongarch support.

On Tue, Oct 11, 2022 at 7:52 PM Lulu Cheng wrote: > > 在 2022/10/12 上午4:57, Caroline Tice 写道: > > I think that if VTV_PAGE_SIZE is not set to the actual size being used by > the system, it could result in some unexpected failures. I believe the > right thing to do in this case, since the size ma

Re: [PATCH v2] LoongArch: Libvtv add loongarch support.

I think that if VTV_PAGE_SIZE is not set to the actual size being used by the system, it could result in some unexpected failures. I believe the right thing to do in this case, since the size may vary, is to get the actual size being used by the system and use that in the definition of VTV_PAGE_S

Re: [PATCH v2] LoongArch: Libvtv add loongarch support.

On Tue, Sep 27, 2022 at 3:04 AM Lulu Cheng wrote: > > v1 - > v2: > > 1. When the macro __loongarch_lp64 is defined, the VTV_PAGE_SIZE is set to > 64K. > 2. In the vtv_malloc.cc file __vtv_malloc_init function, it does not check >whether VTV_PAGE_SIZE is equal to the system page size, if the m

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

I have updated the patch as you suggested, to filter the "-fvtable-verify=std" out of AM_CXXFLAGS, and I have verified that it passes the testsuite with no regressions and fixes the reported bug. Is this OK to commit now? -- Caroline Tice cmt...@google.com libstdc++-v3/ChangeLog 2021-03-12 Car

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

Adding the libstdc++ mailing list to the patch. -- Caroline cmt...@google.com On Wed, Mar 10, 2021 at 8:50 PM Caroline Tice wrote: > > This patch is to fix PR 99172. > > Currently when GCC is configured with --enable-vtable-verify, the > libstdc++-v3 Makefiles add "-fvtable-verify=std > -Wl,-u_v

[PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

This patch is to fix PR 99172. Currently when GCC is configured with --enable-vtable-verify, the libstdc++-v3 Makefiles add "-fvtable-verify=std -Wl,-u_vtable_map_vars_start,-u_vtable_map_vars_end" to libtool link commands. The "-fvtable-verify=std" piece causes alternate versions of libtool (such

[PATCH v1] [include] Add codes for DWARF v5 .dwp sections to dwarf2.h

For DWARF v5 Dwarf Package Files (.dwp files), the section identifier encodings have changed. This patch updates dwarf2.h to contain the new encodings. (see http://dwarfstd.org/doc/DWARF5.pdf, section 7.3.5). This patch has already been committed in binutils, but it needs to go into GCC as well t

[PATCH] Fix testcase to not use vtable verification with LTO

Yesterday I submitted a patch that disallows using vtable verfication with LTO (they don't work properly together), but I missed fixing the flags for one testcase. This patch fixes that omission. Testing: Tescase passes with this change. Is this ok to commit? -- Caroline cmt...@google.com Chang

[PATCH] Disable vtable verification with LTO

Vtable verification currently does not work properly with LTO. Fixing this will be non-trivial, and I currently do not have the time do this. Until this can be fixed, we should not allow users to specify both vtable verification and link-time optimization. The attached patch checks to see if bot

Re: [PATCH] PR other/91396 Fix static link error with -fvtable-verify

The bootstrap succeeded. On Mon, Aug 12, 2019 at 11:51 AM Caroline Tice wrote: > > Hi, > > This patch is to fix a bug where linking with -fvtable-verify and > -static causes the linker to complain about multiple definitions of > things in the vtv_end*.o files (once from the .o file and once from

[PATCH] PR other/91396 Fix static link error with -fvtable-verify

Hi, This patch is to fix a bug where linking with -fvtable-verify and -static causes the linker to complain about multiple definitions of things in the vtv_end*.o files (once from the .o file and once from libvtv.a). (See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91396). The fix is for the G

Re: [PATCH][C++] Fix ICE with VTV

I have managed to reproduce the issue now, and the patch does appear to fix the ICE. There is a second issue, which will need more investigation: When compiled with '-flto' the extra internal functions that VTV generates, and which are necessary for it to work correctly, do not get propagated in

[PATCH, libvtv] Fix testsuite issue.

One of the testsuite tests for libvtv is failing due to an incorrect signature for the function "main". This patch fixes that. Testing: The libvtv testsuite failed 4 tests without this fix; it passes all of them with it. Ok to commit? -- Caroline Tice cmt...@google.com Index: libvtv/ChangeLog

Re: [PATCH][C++] Fix ICE with VTV

On Tue, Feb 19, 2019 at 1:57 AM Richard Biener wrote: > > Looks like vtv_generate_init_routine calls symtab->process_new_functions > () which has seriously bad effects on GCCs internal memory state. > > VTV has zero testsuite coverage it seems and besides its initial > commit didn't receive any l