Re: [libjava] XFAIL sourcelocation (PR libgcj/55637)

2014-02-20 Thread Bryce McKinlay
On Thu, Feb 20, 2014 at 12:05 PM, Rainer Orth wrote: > The libjava sourcelocation output test has been FAILing on mainline for > more than a year, with no sign of anything happening to resolve that. > To reduce testsuite noise, I suggest to XFAIL the test. In all mainline > test results from feb

Re: [PATCH] Fix linking with -findirect-dispatch

2013-04-16 Thread Bryce McKinlay
On Tue, Apr 16, 2013 at 5:13 PM, Andreas Schwab wrote: > Jakub Jelinek writes: > >> I'm pretty sure when the changes were added for gcc 4.2 it worked just fine, > > I'm pretty sure it never worked as intented. It certainly _did_ work as intended previously. Though I've not tested it for a while.

Re: [PATCH] Fix linking with -findirect-dispatch

2013-04-16 Thread Bryce McKinlay
On Tue, Apr 16, 2013 at 9:38 AM, Jakub Jelinek wrote: > On Tue, Apr 16, 2013 at 10:35:29AM +0200, Andreas Schwab wrote: >> Linking with -findirect-dispatch fails with this error: >> >> x86_64-linux-gcj -o ecjx -findirect-dispatch >> --main=org.eclipse.jdt.internal.compiler.batch.GCCMain >> ../..

Re: [boehm-gc] Use thr_stksegment to determine Solaris stack base

2013-03-06 Thread Bryce McKinlay
On Wed, Mar 6, 2013 at 11:31 AM, Rainer Orth wrote: > This patch fixes the failures by backporting the use of thr_stksegment > from gc 7.2c. > > Bootstrapped without regressions on i386-pc-solaris2.{9,10,11} and > sparc-sun-solaris2.{9,10,11}, fixes the i386-pc-solaris2.11 failures. > > Ok for ma

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Bryce McKinlay
On Tue, Sep 4, 2012 at 6:12 PM, Andrew Haley wrote: >> He's also planning to use it for libgo, and other gcc runtime libs >> have indicated interest. It doesn't have to work on all platforms, and >> I can't see how it would be any less portable than addr2line! > > I certainly can. Maybe once it'

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Bryce McKinlay
On Tue, Sep 4, 2012 at 5:39 PM, Andrew Haley wrote: > On 09/04/2012 05:32 PM, Bryce McKinlay wrote: >> On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: >>> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >>>> On 08/30/2012 08:20 AM, Andrew Haley wrot

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Bryce McKinlay
On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: > On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >> On 08/30/2012 08:20 AM, Andrew Haley wrote: >>> Is the problem simply that the logic to >>> scan the assembly code isn't present in the libgcj testsuite? >> >> Yes, exactly. > > For th

Re: [PATCH] Set correct source location for deallocator calls

2012-08-30 Thread Bryce McKinlay
On Thu, Aug 30, 2012 at 3:28 PM, Richard Henderson wrote: > On 08/17/2012 03:02 PM, Dehao Chen wrote: >> I spend a whole day working on this, but find it very difficult to add >> such a java test because: >> >> * First, libjava testsuits are all runtime tests, i.e., it compiles >> the byte code to

Re: [PATCH] [JAVA] Double.parseDouble(null) throw NullPointerException

2011-08-12 Thread Bryce McKinlay
On Fri, Aug 12, 2011 at 8:27 AM, Jie Liu wrote: > The method length() is not a final method, as java/lang/String.java line 447: > >  public int length() >  { >    return count; >  } > > Is this the problem? As String is a final class, all its methods are implicitly final. Bryce