Re: [PATCH] OpenMP: Integrate dynamic selectors with dispatch argument handling [PR118457]

2025-03-08 Thread Sandra Loosemore
On 3/8/25 11:40, Tobias Burnus wrote: [snip] LGTM – but I would prefer if we could make the scan-tree-dump check of the new test case a bit stricter, just to avoid that we accidentally regress on this when modifying the patch. OK. I've pushed the attached version of the patch with a few twe

Re: [wwwdocs v2] gcc-15/changes: Mention the new -mveclibabi=aocl option in the IA-32/x86-64 section

2025-03-08 Thread Filip Kastl
On Fri 2025-03-07 16:36:17, Gerald Pfeifer wrote: > On Fri, 7 Mar 2025, Filip Kastl wrote: > > Here is a second version of the patch. Thanks for the suggestions. I > > addressed them both. Do you think this is better? > > Loving it. :) > > Thank you, > Gerald Ok, pushed. Thanks! Filip

Re: [patch, Fortran] Fix PR 119157, regression with -Wexternal-argument-mismatch

2025-03-08 Thread Thomas Koenig
Am 08.03.25 um 20:29 schrieb Steve Kargl: On Sat, Mar 08, 2025 at 01:52:06PM +0100, Thomas Koenig wrote: While looking at the code, I also saw that a member of gfc_symbol introduced with my patch should be a bitfield of width 1. OK for trunk? OK (assuming a successful regression test run).

Re: [patch, Fortran] Fix PR 119157, regression with -Wexternal-argument-mismatch

2025-03-08 Thread Steve Kargl
On Sat, Mar 08, 2025 at 01:52:06PM +0100, Thomas Koenig wrote: > > the attached patch fixes an ICE regresseion where undo state was not > handled properly when generating formal from actual arguments, which > occurred under certain conditions with the newly introduced > -Wexternal-argument-mismatc

Re: [PATCH v2] libstdc++: constrain std::atomic's default constructor

2025-03-08 Thread Giuseppe D'Angelo
Hello, On 03/12/2024 16:53, Giuseppe D'Angelo wrote: Hello, Following the outcome of the previous discussion, the attached revised patch implements the proposed resolution to LWG 4169, moved to WP in Wrocław. https://cplusplus.github.io/LWG/issue4169 Thanks, An amended patch (attached) has

Re: [PATCH] OpenMP: Integrate dynamic selectors with dispatch argument handling [PR118457]

2025-03-08 Thread Tobias Burnus
Hi Sandra, hello world, sorry for the belated review. Sandra Loosemore wrote: Support for dynamic selectors in "declare variant" was developed in parallel with support for the adjust_args/append_args clauses and the dispatch construct; they collided in a bad way. This patch fixes the "sorry" f

[COMMITTED] inline-asm: Improve documentation of "asm constexpr".

2025-03-08 Thread Sandra Loosemore
While working on an adjacent documentation fix, I noticed that the documentation for the gnu++11 "asm constexpr" feature was very confusing, in some cases being attached to parts of the asm syntax that are not otherwise required to be string literals, and missing from other parts of the syntax that

Re: [PATCH 2/4] c++/modules: Track module purview for deferred instantiations [PR114630]

2025-03-08 Thread Jason Merrill
On 3/7/25 6:19 AM, Nathaniel Shead wrote: On Thu, Mar 06, 2025 at 12:45:33PM -0500, Jason Merrill wrote: On 3/5/25 7:54 AM, Nathaniel Shead wrote: On Wed, Feb 26, 2025 at 10:29:59AM -0500, Jason Merrill wrote: On 2/21/25 6:05 AM, Nathaniel Shead wrote: After seeing PR c++/118964 I'm coming ba

[patch, Fortran] Fix PR 119157, regression with -Wexternal-argument-mismatch

2025-03-08 Thread Thomas Koenig
Hello world, the attached patch fixes an ICE regresseion where undo state was not handled properly when generating formal from actual arguments, which occurred under certain conditions with the newly introduced -Wexternal-argument-mismatch option. The fix is simple: When we are generating these