Re: [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.

2024-05-25 Thread Mariam Arutunian
On Sat, May 25, 2024, 22:34 Jeff Law wrote: > > > On 5/24/24 2:42 AM, Mariam Arutunian wrote: > >gcc/testsuite/gcc.c-torture/compile/ > > > > * crc-11.c: New test. > > * crc-15.c: Likewise. > > * crc-16.c: Likewise. > > * crc-19.c: Likewise. > > * crc-2.c: Likewise. >

Re: [RFC/RFA] [PATCH 04/12] RISC-V: Add CRC built-ins tests for the target ZBC.

2024-05-25 Thread Mariam Arutunian
On Sat, May 25, 2024, 22:35 Jeff Law wrote: > > > On 5/24/24 2:41 AM, Mariam Arutunian wrote: > >gcc/testsuite/gcc.target/riscv/ > > > > * crc-builtin-zbc32.c: New file. > > * crc-builtin-zbc64.c: Likewise. > OK once prerequisites are approved. > > jeff > Thank you. >

[COMMITTED] tree-optimization/115208 - Delete gori_map during destruction of GORI.

2024-05-25 Thread Andrew MacLeod
When a GORI object is constructed, we construct both GORI and a gori_map. During destruction, I neglected to destruct the associated gori_map.  doh!  sorry. Bootstraps on x86_64-pc-linux-gnu with no regressions.  And hopefully resolves everyone's issues. Andrew From e98cf19c2be1ffaf65d625

[PATCH v1] Gen-Match: Fix gen_kids_1 right hand braces mis-alignment

2024-05-25 Thread pan2 . li
From: Pan Li Notice some mis-alignment for gen_kids_1 right hand braces as below: if ((_q50 == _q20 && ! TREE_SIDE_EFFECTS (... { if ((_q51 == _q21 && ! TREE_SIDE_EFFECTS (... {

[PATCH] c++: canonicity of fn types w/ instantiated eh specs [PR115223]

2024-05-25 Thread Patrick Palka
Bootstrap and regtest on x86_64-pc-linux-gnu in progress, does this look OK for trunk if successful? -- >8 -- When propagating structural equality in build_cp_fntype_variant, we should consider structural equality of the exception-less variant, not of the given type which might use structural equ

[committed] [v2] More logical op simplifications in simplify-rtx.cc

2024-05-25 Thread Jeff Law
This is a revamp of what started as a target specific patch. Basically xalan (corrected, I originally thought it was perlbench) has a bitset implementation with a bit of an oddity. Specifically setBit will clear the bit before it is set: if (bitToSet < 32) {

Re: [RFC/RFA] [PATCH 04/12] RISC-V: Add CRC built-ins tests for the target ZBC.

2024-05-25 Thread Jeff Law
On 5/24/24 2:41 AM, Mariam Arutunian wrote:   gcc/testsuite/gcc.target/riscv/     * crc-builtin-zbc32.c: New file.     * crc-builtin-zbc64.c: Likewise. OK once prerequisites are approved. jeff

Re: [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.

2024-05-25 Thread Jeff Law
On 5/24/24 2:42 AM, Mariam Arutunian wrote:   gcc/testsuite/gcc.c-torture/compile/     * crc-11.c: New test.     * crc-15.c: Likewise.     * crc-16.c: Likewise.     * crc-19.c: Likewise.     * crc-2.c: Likewise.     * crc-20.c: Likewise.     * crc-24.c: Likewise.     * crc-29.c: Like

Re: [RFC/RFA] [PATCH 03/12] RISC-V: Add CRC expander to generate faster CRC.

2024-05-25 Thread Jeff Law
On 5/24/24 2:41 AM, Mariam Arutunian wrote: If the target is ZBC or ZBKC, it uses clmul instruction for the CRC calculation. Otherwise, if the target is ZBKB, generates table-based CRC, but for reversing inputs and the output uses bswap and brev8 instructions. Add new tests to check CRC gener

Re: [RFC/RFA] [PATCH 02/12] Add built-ins and tests for bit-forward and bit-reversed CRCs

2024-05-25 Thread Jeff Law
On 5/24/24 2:41 AM, Mariam Arutunian wrote: This patch introduces new built-in functions to GCC for computing bit- forward and bit-reversed CRCs. These builtins aim to provide efficient CRC calculation capabilities. When the target architecture supports CRC operations (as indicated by the pr

Re: [RFC/RFA] [PATCH 01/12] Implement internal functions for efficient CRC computation

2024-05-25 Thread Jeff Law
On 5/24/24 2:41 AM, Mariam Arutunian wrote: Add two new internal functions (IFN_CRC, IFN_CRC_REV), to provide faster CRC generation. One performs bit-forward and the other bit-reversed CRC computation. If CRC optabs are supported, they are used for the CRC computation. Otherwise, table-based

[PATCH] libcpp: Correct typo 'r' -> '\r'

2024-05-25 Thread Peter Damianov
libcpp/ChangeLog: * lex.cc (do_peek_prev): Correct typo in argument to __builtin_expect() Signed-off-by: Peter Damianov --- libcpp/lex.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcpp/lex.cc b/libcpp/lex.cc index c9e44e6..de752bdc9c8 100644 --- a/libcpp/l

[PATCH] vect: Unify bbs in loop_vec_info and bb_vec_info

2024-05-25 Thread Feng Xue OS
Both derived classes ( loop_vec_info/bb_vec_info) have their own "bbs" field, which have exactly same purpose of recording all basic blocks inside the corresponding vect region, while the fields are composed by different data type, one is normal array, the other is auto_vec. This difference causes

[PATCH] vect: Use vect representative statement instead of original in patch recog [PR115060]

2024-05-25 Thread Feng Xue OS
Some utility functions (such as vect_look_through_possible_promotion) that are to find out certain kind of direct or indirect definition SSA for a value, may return the original one of the SSA, not its pattern representative SSA, even pattern is involved. For example, a = (T1) patt_b; pa

[PATCH v3 #1/2] [rs6000] adjust return_pc debug attrs

2024-05-25 Thread Alexandre Oliva
On Apr 27, 2023, Alexandre Oliva wrote: > On Apr 14, 2023, Alexandre Oliva wrote: >> On Mar 23, 2023, Alexandre Oliva wrote: >>> This patch introduces infrastructure for targets to add an offset to >>> the label issued after the call_insn to set the call_return_pc >>> attribute. This will be u

[PATCH v3 #1/2] enable adjustment of return_pc debug attrs

2024-05-25 Thread Alexandre Oliva
On Apr 27, 2023, Alexandre Oliva wrote: > On Apr 14, 2023, Alexandre Oliva wrote: >> On Mar 23, 2023, Alexandre Oliva wrote: >>> This patch introduces infrastructure for targets to add an offset to >>> the label issued after the call_insn to set the call_return_pc >>> attribute. This will be u

Re: [PATCH] Avoid vector -Wfree-nonheap-object warnings

2024-05-25 Thread François Dumont
On 24/05/2024 16:17, Jonathan Wakely wrote: On Thu, 23 May 2024 at 18:38, François Dumont wrote: On 23/05/2024 15:31, Jonathan Wakely wrote: On 23/05/24 06:55 +0200, François Dumont wrote: As explained in this email: https://gcc.gnu.org/pipermail/libstdc++/2024-April/058552.html I experi

[pushed] wwwdocs: gcc-13: Reword section on __bf16

2024-05-25 Thread Gerald Pfeifer
I found this section hard to understand at first (in addition to some grammar issues) so pushed the following. Lingling, please advise if you'd like further changes. Gerald --- htdocs/gcc-13/changes.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/htdocs/gcc-13/

Re: [PATCH] [tree-prof] skip if errors were seen [PR113681]

2024-05-25 Thread Alexandre Oliva
On Apr 16, 2024, Alexandre Oliva wrote: > for gcc/ChangeLog > PR tree-optimization/113681 > * tree-profiling.cc (pass_ipa_tree_profile::gate): Skip if > seen_errors. > for gcc/testsuite/ChangeLog > PR tree-optimization/113681 > * c-c++-common/strub-pr113681.c: N

Re: [PATCH v2] [testsuite] [arm] add effective target and options for pacbti tests

2024-05-25 Thread Alexandre Oliva
On Apr 19, 2024, Alexandre Oliva wrote: > for gcc/testsuite/ChangeLog > * gcc.target/arm/bti-1.c: Require arch, use its opts, drop skip. > * gcc.target/arm/bti-2.c: Likewise. > * gcc.target/arm/acle/pacbti-m-predef-11.c: Likewise. > * gcc.target/arm/acle/pacbti-m-predef-

Re: [PATCH v2] [testsuite] [powerpc] adjust -m32 counts for fold-vec-extract*

2024-05-25 Thread Alexandre Oliva
On Apr 22, 2024, Alexandre Oliva wrote: > for gcc/testsuite/ChangeLog > PR testsuite/101169 > * gcc.target/powerpc/fold-vec-extract-double.p7.c: Adjust addi > counts for ilp32. > * gcc.target/powerpc/fold-vec-extract-float.p7.c: Likewise. > * gcc.target/powerpc/fol

[pushed] wwwdocs: git: Fix typo

2024-05-25 Thread Gerald Pfeifer
Trivial fix. Pushed. Gerald --- htdocs/git.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/git.html b/htdocs/git.html index 22c0eec1..a6e88566 100644 --- a/htdocs/git.html +++ b/htdocs/git.html @@ -236,7 +236,7 @@ additional branches can also be fetched if necessa

Re: [PATCH v2] add explicit ABI and align options to pr88233.c

2024-05-25 Thread Alexandre Oliva
On Apr 22, 2024, Alexandre Oliva wrote: > for gcc/testsuite/ChangeLog > * gcc.target/powerpc/pr88233.c: Make some alignment strictness > and calling conventions assumptions explicit. Restore uniform > codegen expectations Ping? https://gcc.gnu.org/pipermail/gcc-patches/2024