Hi Harald,
Thanks for the review. The attached resubmission fixes all the invalid
accesses, memory leaks and puts right the incorrect result.
In the course of fixing the fix, I found that deferred character length
MOLDs gave an ICE because reallocation on assign was using 'dest_word_len'
before i
We are the industrial hose supplier in China.
Do you need that kind hose?
More information and catalog can be send if you need.
Waiting for your news.
Best regards
Jessie
Hello Alex:
All comments are addressed.
Common infrastructure of load store pair fusion is divided into target
independent and target dependent changed code.
Target independent code is the Generic code with pure virtual function
to interface betwwen target independent and dependent code.
Target
On 5/10/24 4:28 PM, Jeff Law wrote:
So this patch fixes a minor code generation inefficiency that (IIRC) the
RAU team discovered a while ago in spec.
If we want the inverted value of a single bit we can use bext to extract
the bit, then seq to invert the value (if viewed as a 0/1 truth value
On 5/7/24 4:34 AM, Jan Hubicka wrote:
Hi,
this adds Cauldron2024 to main page. OK?
OK, of course.
jeff
On 5/7/24 11:17 PM, Christoph Müllner wrote:
The current implementation of riscv_block_move_straight() emits a couple
of loads/stores with with maximum width (e.g. 8-byte for RV64).
The remainder is handed over to move_by_pieces().
The by-pieces framework utilizes target hooks to decide about
On 5/7/24 11:17 PM, Christoph Müllner wrote:
This patch adds the field overlap_op_by_pieces to the struct
riscv_tune_param, which is used by the TARGET_OVERLAP_OP_BY_PIECES_P()
hook. This hook is used by the by-pieces infrastructure to decide
if overlapping memory accesses should be emitted.
On 5/7/24 11:17 PM, Christoph Müllner wrote:
The RISC-V cpymemsi expansion is called, whenever the by-pieces
infrastructure will not take care of the builtin expansion.
The code emitted by the by-pieces infrastructure may emits code,
that includes unaligned accesses if riscv_slow_unaligned_acc
So this patch fixes a minor code generation inefficiency that (IIRC) the
RAU team discovered a while ago in spec.
If we want the inverted value of a single bit we can use bext to extract
the bit, then seq to invert the value (if viewed as a 0/1 truth value).
The RTL is fairly convoluted, but
Le 10/05/2024 à 21:24, Harald Anlauf a écrit :
Dear all,
the attached simple and obvious patch fixes a bogus recursion error
with inquiry refs used statement functions. The commit message
says all there is to say...
Regtested on x86_64-pc-linux-gnu.
I intend to commit to mainline within the n
On Fri, May 10, 2024 at 1:23 PM Jason Merrill wrote:
>
> On 5/10/24 12:14, Ken Matsui wrote:
> > Removed the redundant check and fixed the flow. Could you please review
> > this
> > again?
>
> Looks good! All the compiler trait patches are OK.
Thank you so much for your reviews!
>
> > -- >8 -
On 5/10/24 12:14, Ken Matsui wrote:
Removed the redundant check and fixed the flow. Could you please review this
again?
Looks good! All the compiler trait patches are OK.
-- >8 --
This patch implements built-in trait for std::is_invocable.
gcc/cp/ChangeLog:
* cp-trait.def: Define
On 5/9/24 14:20, Jakub Jelinek wrote:
On Thu, Apr 25, 2024 at 11:30:48AM -0400, Jason Merrill wrote:
Hmm, maybe maybe_clone_body shouldn't clear DECL_SAVED_TREE for aliases, but
rather set it to some stub like void_node?
Though with all these changes, it's probably better to go with your first
Am 10.05.24 um 21:48 schrieb Harald Anlauf:
Hi Mikael,
Am 10.05.24 um 11:45 schrieb Mikael Morin:
Le 09/05/2024 à 22:30, Harald Anlauf a écrit :
I'll stop here...
Thanks. Go figure, I have no problem reproducing today.
It's PR99798 (and there is even a patch for it).
this patch has rotten
Hi Mikael,
Am 10.05.24 um 11:45 schrieb Mikael Morin:
Le 09/05/2024 à 22:30, Harald Anlauf a écrit :
I'll stop here...
Thanks. Go figure, I have no problem reproducing today.
It's PR99798 (and there is even a patch for it).
this patch has rotten a bit: the type of gfc_reluease_symbol
has ch
On 5/9/24 16:29, Patrick Palka wrote:
On Thu, 9 May 2024, Patrick Palka wrote:
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look
OK for trunk/14? For trunk as a follow-up I can implement the
mentionted representation change to use CALL_EXPR instead of
MODOP_EXPR for a non-depen
On 5/9/24 16:23, Patrick Palka wrote:
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look
OK for trunk/14? For trunk as a follow-up I can implement the
mentionted representation change to use CALL_EXPR instead of
MODOP_EXPR for a non-dependent simple assignment expression that
reso
Hi Jan,
> On Friday 2024-05-10 15:59, Rainer Orth wrote:
>>Stuff Received writes:
>>
>>> On 2024-05-10 07:44, Rainer Orth wrote (in part):
>>>
Besides, if John had ever tried to build either GCC 13 or 14 on Solaris
11.3, gcc/configure would have told him about the obsoletion in no
On Friday 2024-05-10 15:59, Rainer Orth wrote:
>Stuff Received writes:
>
>> On 2024-05-10 07:44, Rainer Orth wrote (in part):
>>
>>> Besides, if John had ever tried to build either GCC 13 or 14 on Solaris
>>> 11.3, gcc/configure would have told him about the obsoletion in no
>>> uncertain terms.
Dear all,
the attached simple and obvious patch fixes a bogus recursion error
with inquiry refs used statement functions. The commit message
says all there is to say...
Regtested on x86_64-pc-linux-gnu.
I intend to commit to mainline within the next 24 hours unless someone
screams... Will also
The register class checks in the multiply-source predicates was
incorrectly using the register number instead of the register
class for comparison.
This has slipped through all regression tests because the mulsi3 pattern
was expanded with pseudo registers. So the faulty predicate comparison
was no
Hello Alex:
All comments are addressed.
Common infrastructure of load store pair fusion is divided into target
independent and target dependent changed code.
Target independent code is the Generic code with pure virtual function
to interface betwwen target independent and dependent code.
Target
The following patch solves
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114942
The patch was successfully bootstrapped and tested on x86-64, ppc64le,
aarch64.
commit 9585317f0715699197b1313bbf939c6ea3c1ace6
Author: Vladimir N. Makarov
Date: Fri May 10 09:15:50 2024 -0400
[PR114942][LRA]
Removed the redundant check and fixed the flow. Could you please review this
again?
-- >8 --
This patch implements built-in trait for std::is_invocable.
gcc/cp/ChangeLog:
* cp-trait.def: Define __is_invocable.
* constraint.cc (diagnose_trait_expr): Handle CPTK_IS_INVOCABLE.
On Fri, May 10, 2024 at 8:27 AM Jason Merrill wrote:
>
> On 5/10/24 10:45, Ken Matsui wrote:
> > Fixed the incorrect if condition. Could you please review this again?
> >
> > -- >8 --
> >
> > This patch implements built-in trait for std::is_invocable.
> >
> > gcc/cp/ChangeLog:
> >
> > * cp-
On 5/10/24 10:45, Ken Matsui wrote:
Fixed the incorrect if condition. Could you please review this again?
-- >8 --
This patch implements built-in trait for std::is_invocable.
gcc/cp/ChangeLog:
* cp-trait.def: Define __is_invocable.
* constraint.cc (diagnose_trait_expr): Handl
gcc/ChangeLog:
PR tree-optimization/115026
* value-range.cc (prange::update_bitmask): Use operand bitmask.
---
gcc/value-range.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index 3e1ecf69517..5bcb2c3f650 100644
--- a
Fixed the incorrect if condition. Could you please review this again?
-- >8 --
This patch implements built-in trait for std::is_invocable.
gcc/cp/ChangeLog:
* cp-trait.def: Define __is_invocable.
* constraint.cc (diagnose_trait_expr): Handle CPTK_IS_INVOCABLE.
* semanti
On Fri, May 10, 2024 at 7:20 AM Jason Merrill wrote:
>
> On 5/10/24 07:24, Ken Matsui wrote:
> > Fixed the reference to pointer to class case. Ok for trunk?
> >
> > -- >8 --
> >
> > This patch implements built-in trait for std::is_invocable.
> >
> > gcc/cp/ChangeLog:
> >
> > * cp-trait.def:
On Fri, May 10, 2024 at 02:50:56PM +0200, Richard Biener wrote:
> But for example a reg-reg move when optimizing for speed could have
> a zero associated cost.
Sure, but this is the way things always have been. I'm sure there are
ways to change things so they become slightly easier to use, but th
On 5/10/24 07:24, Ken Matsui wrote:
Fixed the reference to pointer to class case. Ok for trunk?
-- >8 --
This patch implements built-in trait for std::is_invocable.
gcc/cp/ChangeLog:
* cp-trait.def: Define __is_invocable.
* constraint.cc (diagnose_trait_expr): Handle CPTK_IS_
Stuff Received writes:
> On 2024-05-10 07:44, Rainer Orth wrote (in part):
>
>> Besides, if John had ever tried to build either GCC 13 or 14 on Solaris
>> 11.3, gcc/configure would have told him about the obsoletion in no
>> uncertain terms.
>
> No, the option --enable-obsolete has allowed me to
Greetings, Rainer.
On 2024-05-10 07:44, Rainer Orth wrote (in part):
Besides, if John had ever tried to build either GCC 13 or 14 on Solaris
11.3, gcc/configure would have told him about the obsoletion in no
uncertain terms.
No, the option --enable-obsolete has allowed me to build on my T2000
On Thu, 9 May 2024, Patrick Palka wrote:
> On Thu, 9 May 2024, Patrick Palka wrote:
>
> > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look
> > OK for trunk/14? For trunk as a follow-up I can implement the
> > mentionted representation change to use CALL_EXPR instead of
> > MODOP
When loop distribution releases a PHI node of the original IL it
can end up clobbering memory that's re-used when it upon releasing
its RDG resets all stmt UIDs back to -1, even those that got released.
The fix is to avoid resetting UIDs based on stmts in the RDG but
instead reset only those still
On Fri, May 10, 2024 at 3:18 PM Robin Dapp wrote:
>
> Hi,
>
> this only forces the first comparison operator into a register if it is
> not already suitable.
>
> Bootstrap and regtest is running on x86 and aarch64, successful on p10.
> Regtested on riscv.
How does this make a difference in the en
Hi,
this only forces the first comparison operator into a register if it is
not already suitable.
Bootstrap and regtest is running on x86 and aarch64, successful on p10.
Regtested on riscv.
gcc/ChangeLog:
PR middle-end/113474
* internal-fn.cc (expand_vec_cond_mask_optab_fn): O
On Fri, Mar 1, 2024 at 10:21 AM Richard Biener wrote:
>
> The following removes the over-broad rejection of patterns for SLP
> reductions which is done by removing them from LOOP_VINFO_REDUCTIONS
> during pattern detection. That's also insufficient in case the
> pattern only appears on the reduct
On Fri, May 10, 2024 at 12:55 PM Di Zhao OS
wrote:
>
> This patch tries to fix pr114760 by checking for the
> variants explicitly. When recognizing bit counting idiom,
> include pattern "x * 2" for "x << 1", and "x / 2" for
> "x >> 1" (given x is unsigned).
>
> Bootstrapped and tested on x86_64-li
On Fri, May 10, 2024 at 12:54 PM Segher Boessenkool
wrote:
>
> On Fri, May 10, 2024 at 12:19:35PM +0200, Richard Biener wrote:
> > On Fri, May 10, 2024 at 11:06 AM Segher Boessenkool
> > wrote:
> > > *All* code using a cost will have to be inspected and possibly adjusted
> > > if you decide to us
This patch resolves PR114915 by replacing the logic that fills in the missing
levels in do_auto_deduction in cp/pt.cc.
The new approach now trims targs if the depth of targs is deeper than desired
(this will only happen in specific contexts), and still fills targs with empty
layers if it has few
Thanks for your suggestions. I will apply them in the upcoming patch (v3).
On Mon, May 6, 2024 at 7:46 PM Patrick Palka wrote:
> We could also/instead consider defining
>
> int want = TEMPLATE_TYPE_ORIG_LEVEL (auto_node);
> int have = TMPL_ARGS_DEPTH (full_targs);
>
> and express the logic in ter
Hi Richard,
Thanks for your comments.
在 2024/5/10 15:16, Richard Biener 写道:
> But if targets return sth < COSTS_N_INSNS (1) but > 0 this is now no
> longer meaningful. So shouldn't it instead be
>
> return cost > 0 ? cost : 1;
Yes, it's better.
>
> ? Alternatively returning fractions of C
Hi Adrian,
>> > While Oracle does no longer provide feature updates to Solaris 11.3, there
>> > is still LTSS security support so that users still receive security updates
>> > so that their systems are continued to be protected against
>> > vulnerabilities.
>>
>> The Solaris 11.3 ESUs (Extended
Hi John,
> On Fri, 2024-05-10 at 12:14 +0200, Richard Biener wrote:
>> > Because I wasn't subscribed to gcc-patches and I'm also only subscribed now
>> > without receiving messages due to the large message volume on this list.
>>
>> https://gcc.gnu.org/gcc-13/changes.html
>>
>> > The problem wit
Hi Richard,
> On Fri, May 10, 2024 at 10:54 AM John Paul Adrian Glaubitz
> wrote:
>>
>> Hello Rainer,
>>
>> On Fri, 2024-05-10 at 10:20 +0200, Rainer Orth wrote:
>> > > > Support for Solaris 11.3 had already been obsoleted in GCC 13.
>> > > > However,
>> > > > since the only Solaris system in t
Fixed the reference to pointer to class case. Ok for trunk?
-- >8 --
This patch implements built-in trait for std::is_invocable.
gcc/cp/ChangeLog:
* cp-trait.def: Define __is_invocable.
* constraint.cc (diagnose_trait_expr): Handle CPTK_IS_INVOCABLE.
* semantics.cc (tra
On Thu, May 9, 2024 at 9:16 AM Jason Merrill wrote:
>
> On 5/8/24 01:04, Ken Matsui wrote:
> > Fixed the reference_wrapper case. I used non_ref_datum_type to avoid
> > potentially multiple build_trait_object calls.
> >
> > -- >8 --
> >
> > This patch implements built-in trait for std::is_invocabl
On Fri, May 10, 2024 at 4:29 AM j...@pawlicker.com j...@pawlicker.com <
j...@pawlicker.com> wrote:
> The problem with illumos on SPARC is; illumos is also removing SPARC
> support piece by piece, especially as it gets in the way of what they want
> to do with the OS on x86-64 machines (which is wh
On Tue, 7 May 2024 at 15:11, Jonathan Wakely wrote:
>
> On Tue, 7 May 2024 at 15:06, Jonathan Wakely wrote:
> >
> > On Tue, 7 May 2024 at 14:57, Jeff Law wrote:
> > >
> > >
> > >
> > > On 5/7/24 7:49 AM, Jonathan Wakely wrote:
> > > > Do we want this change for RISC-V, to fix PR113578?
> > > >
> >
This patch tries to fix pr114760 by checking for the
variants explicitly. When recognizing bit counting idiom,
include pattern "x * 2" for "x << 1", and "x / 2" for
"x >> 1" (given x is unsigned).
Bootstrapped and tested on x86_64-linux-gnu.
Thanks,
Di Zhao
---
gcc/ChangeLog:
PR tree-op
On Fri, May 10, 2024 at 12:19:35PM +0200, Richard Biener wrote:
> On Fri, May 10, 2024 at 11:06 AM Segher Boessenkool
> wrote:
> > *All* code using a cost will have to be inspected and possibly adjusted
> > if you decide to use a different value for "unknown" than what we have
> > had for ages. A
On Fri, 2024-05-10 at 12:14 +0200, Richard Biener wrote:
> > Because I wasn't subscribed to gcc-patches and I'm also only subscribed now
> > without receiving messages due to the large message volume on this list.
>
> https://gcc.gnu.org/gcc-13/changes.html
>
> > The problem with announcements on
I would much prefer the IPA experts to fix the pass, but I'm afraid I
don't understand the code enough to do so.
Could someone lend a hand here?
Aldy
On Fri, May 10, 2024 at 12:26 PM Richard Biener
wrote:
>
> On Fri, May 10, 2024 at 11:24 AM Aldy Hernandez wrote:
> >
> > There are various calls
On Fri, May 10, 2024 at 11:24 AM Aldy Hernandez wrote:
>
> There are various calls into fold_range() that have the wrong type
> associated with the range temporary used to hold the result. This
> used to work, because we could store either integers or pointers in a
> Value_Range, but is no longer
On Fri, May 10, 2024 at 11:06 AM Segher Boessenkool
wrote:
>
> On Fri, May 10, 2024 at 04:50:10PM +0800, HAO CHEN GUI wrote:
> > Hi Richard,
> > Thanks for your comments.
> >
> > 在 2024/5/10 15:16, Richard Biener 写道:
> > > But if targets return sth < COSTS_N_INSNS (1) but > 0 this is now no
> >
On Fri, May 10, 2024 at 10:54 AM John Paul Adrian Glaubitz
wrote:
>
> Hello Rainer,
>
> On Fri, 2024-05-10 at 10:20 +0200, Rainer Orth wrote:
> > > > Support for Solaris 11.3 had already been obsoleted in GCC 13. However,
> > > > since the only Solaris system in the cfarm was running 11.3, I've k
Le 09/05/2024 à 22:30, Harald Anlauf a écrit :
Hi Mikael,
Am 09.05.24 um 21:51 schrieb Mikael Morin:
Hello,
Le 06/05/2024 à 21:33, Harald Anlauf a écrit :
Dear all,
I've been contemplating whether to submit the attached patch.
It addresses an ICE-on-invalid as reported in the PR, and also
fi
Hi,
This patch enables overlapped by-piece operations. On rs6000, default
move/set/clear ratio is 2. So the overlap is only enabled with compare
by-pieces.
Compared to previous version, the change is to remove power8
requirement from test case.
https://gcc.gnu.org/pipermail/gcc-patches/2024-Ma
There are various calls into fold_range() that have the wrong type
associated with the range temporary used to hold the result. This
used to work, because we could store either integers or pointers in a
Value_Range, but is no longer the case with prange's. Now you must
explicitly state which type
On Fri, May 10, 2024 at 04:50:10PM +0800, HAO CHEN GUI wrote:
> Hi Richard,
> Thanks for your comments.
>
> 在 2024/5/10 15:16, Richard Biener 写道:
> > But if targets return sth < COSTS_N_INSNS (1) but > 0 this is now no
> > longer meaningful. So shouldn't it instead be
> >
> > return cost > 0
Hi!
On Fri, May 10, 2024 at 09:16:26AM +0200, Richard Biener wrote:
> On Fri, May 10, 2024 at 4:25 AM HAO CHEN GUI wrote:
> >But if set_src_cost returns a value less than COSTS_N_INSNS (1), it's
> > untouched and just returned by pattern_cost. Thus "zero" from set_src_cost
> > is higher than
Hello Rainer,
On Fri, 2024-05-10 at 10:20 +0200, Rainer Orth wrote:
> > > Support for Solaris 11.3 had already been obsoleted in GCC 13. However,
> > > since the only Solaris system in the cfarm was running 11.3, I've kept
> > > it in tree until now when both Solaris 11.4/SPARC and x86 systems ha
Hi John,
>> Support for Solaris 11.3 had already been obsoleted in GCC 13. However,
>> since the only Solaris system in the cfarm was running 11.3, I've kept
>> it in tree until now when both Solaris 11.4/SPARC and x86 systems have
>> been added.
>>
>> This patch actually removes the Solaris 11.
Hi,
Ping this patch, look forward to comments.
Jeff (Jiufu Guo)
Jiufu Guo writes:
> Hi,
>
> As known there are a few PRs (meta-bug PR101926) about
> accessing aggregate param/returns which are passed through registers.
>
> We could use the current SRA pass in a special mode right before
> R
On Fri, May 10, 2024 at 3:41 PM Roger Sayle wrote:
>
>
> Many thanks for the speedy review and correction/improvement.
> It's interesting that you spotted the ternlog "spill"...
> I have a patch that rewrites ternlog handling that's been
> waiting for stage 1, that would also fix this mem operand
The BPF backend was emitting memory operands in pseudo-C syntax
without surrounding parentheses. These were being provided in the
corresponding instruction templates.
This was causing GCC emitting invalid instructions when finding inline
assembly with memory operands like:
asm volatile (
Many thanks for the speedy review and correction/improvement.
It's interesting that you spotted the ternlog "spill"...
I have a patch that rewrites ternlog handling that's been
waiting for stage 1, that would also fix this mem operand
issue. I hope to submit it for review this weekend.
Thanks a
On Fri, May 10, 2024 at 4:25 AM HAO CHEN GUI wrote:
>
> Hi,
>The cost return from set_src_cost might be zero. Zero for
> pattern_cost means unknown cost. So the regularization converts the zero
> to COSTS_N_INSNS (1).
>
>// pattern_cost
>cost = set_src_cost (SET_SRC (set), GET_MODE (SE
In a world with same sized pointers we can always reuse the storage
slots, but since this is not always the case, we need to be more
careful. However, we can always store an undefined, because that
requires no extra storage.
gcc/ChangeLog:
PR tree-optimization/115009
* value-rang
70 matches
Mail list logo
